Skip to content

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Jan 16, 2026

Rationale

#778 No result when trying to select 100,000 rows when a filter is applied

Two things going on here:

  1. for some reason on nightly, the selectAll post is responding with what looks like JSON but is being parsed as HTML so it is hitting a JS error when trying to get / use the "count" from the response
  2. the user doesn't know that something is happening after they click on the "Select All / 100,000 Rows" button, as there is no loading spinner or disabled button in the case where the call takes some time

This PR addresses both. 1 by using jsonData to post to the selectAll API. 2 by disabling the selection buttons after click and using a loading spinner in the "Selected X of Y" text.

Related Pull Requests

Changes

  • Track selection loading state on DataRegion so we can disable buttons and prevent another click
  • DataRegion selectAll to use jsonData for Ajax request instead of params

@cnathe cnathe self-assigned this Jan 16, 2026
@cnathe cnathe requested a review from labkey-nicka January 16, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants