Skip to content

Conversation

@5ec1cff
Copy link
Contributor

@5ec1cff 5ec1cff commented Jun 13, 2025

No description provided.

@5ec1cff 5ec1cff changed the title fix permission signature check on android 16 fix permission signature check bypass on android 16 Jun 13, 2025
@5ec1cff 5ec1cff requested a review from Copilot June 13, 2025 18:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the permission signature check bypass to cover Android 16 by matching any preparePackage* method instead of only preparePackageLI, and adds version-specific references.

  • Broadens stack-trace check to match preparePackage* methods
  • Adds comments linking to Android source references for R-Sv2, T-V, and Android 16
  • Replaces the old method-name equality check with a prefix-based check
Comments suppressed due to low confidence (3)

app/src/main/java/toolkit/coderstory/CorePatchForR.java:273

  • [nitpick] Verify the preference key "digestCreak" is spelled correctly; it may be a typo for "digestCrack" which could lead to unexpected defaults.
if (prefs.getBoolean("digestCreak", true) &&

app/src/main/java/toolkit/coderstory/CorePatchForR.java:274

  • Matching any method starting with "preparePackage" may be too broad and could allow unintended bypasses; consider restricting to specific method names or verifying the caller class.
.anyMatch((o) -> o.getMethodName().startsWith("preparePackage"))

app/src/main/java/toolkit/coderstory/CorePatchForR.java:273

  • There are no tests covering this new bypass logic for Android 16; adding unit or integration tests will help ensure future changes don’t break it.
if (prefs.getBoolean("digestCreak", true) &&

@aviraxp aviraxp merged commit 34a1213 into main Jun 13, 2025
1 check passed
@aviraxp aviraxp deleted the a16 branch June 13, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants