Pr liigo/libuv vc6 002 #16
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports a Unix process spawning fix from InstantWebP2P/libuvpp into liigo/libuv-vc6.
It addresses an issue in Unix process spawning logic in
src/unix/process.cthat could cause incorrect behavior in specific spawn scenarios (e.g. stdio inheritance, environment handling, exit status reporting, signal handling, or edge-case argument handling). The change also updatestest/test-spawn.cto ensure the corrected behavior is covered by regression tests.commit
src/unix/process.cto behave consistently and correctly in the affected edge case, and extendstest/test-spawn.cto validate the fix and prevent regressions.Why it fits this repo’s guidelines/policies
test-spawn; no unrelated refactors.Notes (if any adaptations): Ported cleanly from
InstantWebP2P/libuvppwith no intended functional changes beyond applying the fix and associated tests.Why it’s useful here
test-spawncoverage.Testing
test/test-spawn.cso CI/maintainers can validate using the refreshed regression coverage.