-
-
Notifications
You must be signed in to change notification settings - Fork 525
feat: add swaync wallbash support (alpha) #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: add swaync wallbash support (alpha) #515
Conversation
|
Cool. I have been using swaync for months now. Swaync works pretty well except for the GTK bug. |
|
I use swaync for a long time too. What do you mean gtk bug. Seems like I've never seen it?🤔 |
|
I'll compile a screenshot later. |
|
BTW how was the waybar rework? Should we make a dev branch and make a channel for dev Branch in discord? This way it is unlikely to break the master Branch. We needed testers in the dev branch who are able to test changes. |
|
Waybar rework is great 👍 I agree with you. I think it's stable enough to be test. 😂 |
|
Imo Maybe the gtk bug is because there's some css feature it doesn't support. I'm working on a standalone config and css, so it's ok for general usage. |
|
Oh btw the new waybar rework doesn't recognize the old font setting in hyde.conf, I need to manually configure in waybar user config file (css if I don't get it wrong). Edit: Another problem is, when I have so many windows open, the right part just squeezed out of the screen🤣 Idk if we can fix it by scripts, or only by upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to reload all
swaync-client -R && swaync-client -rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$HOME/.config/swaync/theme.css | hyprctl dispatch -q exec -- "swaync-client -R && swaync-client -rs"
/* Import wallbash */
@import "<<HOME>>/.cache/hyde/wallbash/gtk.css";
/*
*
* control center
*
* */
/* background */
@define-color sw-cc-bg #<wallbash_pry1>;
/* border */
@define-color sw-cc-border-bg #<wallbash_pry4>;
/*
*
* notification title 'the notification word on control center'
*
* */
/* foreground */
@define-color sw-noti-titl-fg #<wallbash_pry3>;
/* shadow */
@define-color sw-noti-titl-shad #<wallbash_pry4>;
/*
*
* notification window
*
* */
/* background */
@define-color sw-noti-window-bg #<wallbash_pry1>;
/* border */
@define-color sw-noti-window-br #<wallbash_pry4>;
/* color */
@define-color sw-noti-window-txt #<wallbash_txt2>;
/* hover */
@define-color sw-noti-bg-hover #<wallbash_pry2>;
/*
*
* summary message
*
* */
/* foreground */
@define-color sw-msg-sum-fg #<wallbash_pry3>;
/* shadow */
@define-color sw-msg-sum-shad #<wallbash_pry4>;
/* time */
@define-color sw-msg-time #<wallbash_pry4>;
/* body */
@define-color sw-msg-body #<wallbash_pry4>;
/*
*
* notification group
*
* */
/* icon */
@define-color sw-noti-gr-icon #<wallbash_pry4>;
/* button */
@define-color sw-noti-gr-collapse-but-hvr #<wallbash_pry4>;
/* icon */
@define-color sw-noti-gr-collapse-but-icon #<wallbash_pry4>;
/* button */
@define-color sw-noti-gr-close-btn-hvr #<wallbash_pry4>;
/* icon */
@define-color sw-noti-gr-close-btn-icon #<wallbash_pry4>;
/*
*
* clear all button
*
* */
/* background */
@define-color sw-clr-btn-bg #<wallbash_pry3>;
/* foreground */
@define-color sw-clr-btn-fg #<wallbash_pry4>;
/* border */
@define-color sw-clr-btn-br #<wallbash_pry4>;
/* background */
@define-color sw-clr-btn-hvr-bg #<wallbash_pry2>;
/* foreground */
@define-color sw-clr-btn-hvr-fg #<wallbash_pry4>;
/*
*
* DND 'don't disturb
*
* */
/* foreground */
@define-color sw-dnd-fg #<wallbash_pry4>;
/* shadow */
@define-color sw-dnd-shad #<wallbash_4xa1>;
/* background */
@define-color sw-dnd-btn-bg #<wallbash_pry3>;
/* border */
@define-color sw-dnd-btn-br #<wallbash_pry4>;
/* when checked */
@define-color sw-dnd-btn-chk #<wallbash_pry2>;
/* rounded slider */
@define-color sw-dnd-sli-bg #<wallbash_pry4>;
/*
*
* mpris
*
* */
/* foreground */
@define-color sw-mpris-fg #<wallbash_pry4>;
/* background */
@define-color sw-mpris-bg alpha(#<wallbash_pry3>, 0);
/*
*
* Buttons Grid
*
* */
/* background */
@define-color sw-btn-grd-bg alpha(#<wallbash_pry4>, 0.1);
/* foreground */
@define-color sw-btn-grd-fg #<wallbash_pry4>;
/* hover */
@define-color sw-btn-grd-hvr-bg #<wallbash_pry2>;
/*
*
* Volume Widget
*
* */
/* background */
@define-color sw-vol-wid-bg alpha(#<wallbash_pry4>, 0.1);
/* foreground */
@define-color sw-vol-wid-fg #<wallbash_pry4>;
/*
*
* Brightness Widget
*
* */
/* background */
@define-color sw-bright-wid-bg alpha(#<wallbash_pry4>, 0.1);
/* foreground */
@define-color sw-bright-wid-fg #<wallbash_pry4>;
/* NOTE: this is here for testing */
/* @define-color red rgb(247, 83, 65); */
/*
* Wallbash colors for tweaking
* please use ` alpha(#hex, alpha) ` to set the alpha value
* to achieve the rgba effect
*/
Try to use this template. swaync has limited elements so I think it's fine to explicitly declare them to be refined further.
Also importing the gtk css so that wallbash colors can be extended further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea.
i'll do it.
05bd74b to
d09adf3
Compare
|
@kRHYME7 I think this can be merged for test now😆 |
|
hmmm? Anything goes wrong or should I fix something? Or we're not going to support swaync as part of wallbash?🙃 |
|
Ops Sorry I accidentally nuke dev branch! I can't reopen PRs because I forgot some of them, including this one. |
|
@kRHYME7 Maybe it's good to merge this for testing? Or you have any other awesome idea?🤣 |
|
There's an implementation I want for this. Like the waybar implementation. If we started merging this now we might populate unwanted/stray files too early. as this is following the dev branch you should find someone who could test this. Let's reach out @HyDE-Project/testers Spoiler alert, dunst is more stable than swaync. This is based on current experience. I will be testing on this Branch too |
|
@Jax-Tsai-zero please routinely update this branch when the dev branch is updated. Thank you |
|
Got it👍👍 |
|
So the bug mentioned is the users GTK customizations (~/.config/gtk-4.0/gtk.css) overriding the stock swaync CSS values, like the window background, making it gray instead of transparent. The latest version should fix this where the default CSS overrides those changes :) More info here: ErikReider/SwayNotificationCenter#592 |
|
Thank you, @ErikReider BTW I am very curious if manpage swaync 0.12.1-1
|
|
The "application" level is a lower priority than "user" (which your gtk overrides uses). So if you have anything in your overrides changing the window background color, it will affect swaync, so a user level is needed to override those overrides sadly... nothing that i can do other than provide workarounds More info here: |
Noted, basically we should use Thank you for dropping by. |
No one really used those overrides with gtk 3 as they weren't needed, so picked the lowest priority for some reason. But now when gtk 4 has removed specifying a theme, people started using it and I deeply regret defaulting to the application priority xD |
…c_wallbash_alpha
…c_wallbash_alpha
…c_wallbash_alpha
… into swaync_wallbash_alpha
|
@Jax-Tsai-zero how about I merge this silently so we can have the files upstream. We will just omit the restore_cfg.psv for now therefore swaync configs will not be available in the installation until ready. |
|
ok, I'll just move back to dunst. |
|
Have you tested the latest -git version? |
To be clear, the configs will be shipped with HyDE, but the installation part will not be available yet. I have been daily driving swaync for months now without any issues. We have similar configs. However, I would like to know the status of this feature: ErikReider/SwayNotificationCenter#607. @ErikReider, could you shed some light on whether this is possible? If it is not possible, we can implement workarounds on our side. But if you have the time to implement this, it would be worth waiting, since the workaround would be a breaking change. |




wallbash support for swaync, tested.
(alpha version and still optimizing)