fix: preserve %run and %fs magic commands in notebook cells#30
Merged
Conversation
The handleMagicInPythonCell function was stripping %run (and %fs) from cell content because only %pip was exempted from the removeMagicCommand path. Since %run and %fs cells are Python-language cells that need their magic command prefix preserved (just like %pip), they must be handled the same way — keeping the content intact and only updating metadata. https://claude.ai/code/session_01HgXdZmSTBP8XnqTpYQHEQB
Hazzng
force-pushed
the
claude/fix-notebook-run-command-8rdja
branch
from
00976c7 to
69c1fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%runand%fsmagic commands were being stripped from cell content when the notebook rendered. ThehandleMagicInPythonCellfunction only preserved%pipas a special case, but%runand%fsare also Python-language cells that need their magic command prefix kept intact.Root Cause
In
extension.ts,handleMagicInPythonCellhad a special case for%pipto keep it visible in the cell, but%runand%fsfell through to theremoveMagicCommandpath — which stripped the prefix thinking the user had changed the cell language back to Python.Fix
Extended the preservation logic to cover
%runand%fsalongside%pip, using a sharedmagicTypeMaplookup instead of a single%pipcheck.Test plan
%runin cell content%runcells includes# MAGIC %runprefixhttps://claude.ai/code/session_01HgXdZmSTBP8XnqTpYQHEQB