[Feature] [Bugfix] 资源包有关优化与修复 #4980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
需要懂其他语言的人完善 i18n |
在BMC4中测试时发现BMC4会判定所有资源包兼容，与原版表现不符，会导致启用/禁用功能失效，故添加警告
3gf8jv4dv
reviewed
Dec 17, 2025
HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackFile.java
Outdated
Show resolved
Hide resolved
Contributor
|
我下载了 Translations for Sodium，放在 1.21.9~1.21.11 的资源包文件夹内，启动器会显示「游戏版本元数据缺失」。1.21.8 和 1.21.1 正常。不知道是不是 bug。 |
Co-authored-by: 3gf8jv4dv <[email protected]>
Co-authored-by: 3gf8jv4dv <[email protected]>
Contributor
Author
确实是，我在修 |
…esourcepack-enhancement
Contributor
Author
Solved |
Contributor
Author
用户在尝试启用/禁用资源包的时候会弹提示的，虽然只弹一次但是会给5s阅读时间 |
WhatDamon
reviewed
Dec 26, 2025
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackFile.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (3)
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/UpdatesPage.java:305
- In the UpdateTask constructor, the lambda on line 295 captures the
isDisabledvariable and usesModManager.DISABLED_EXTENSION. While ModManager inherits this constant from LocalFileManager, it would be clearer and more maintainable to useLocalFileManager.DISABLED_EXTENSIONsince this code now works with generic LocalAddonFile instances that could be from ResourcePackManager as well.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java:164 - This method overrides LocalAddonFile.setOld; it is advisable to add an Override annotation.
public void setOld(boolean old) throws IOException {
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java:103
- This method overrides LocalAddonFile.getFile; it is advisable to add an Override annotation.
public Path getFile() {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ResourcePackZipFile.java
Outdated
Show resolved
Hide resolved
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
Calboot
changed the title
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
具体改动
LocalAddonFile和LocalFileManager<T extends LocalAddonFile>，使更新对于模组以外的东西（如资源包和光影包）也能适用，从而实现了资源包更新（不保留旧版本）