[Issue #7636] Remove/cleanup TODOs in API code #7639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
chay-REIsys,
hao10282025-sudo,
jakobpederson,
joshtonava,
kkrug and
mdragon
as code owners
chouinar
commented
Dec 22, 2025
Comment on lines
-107
to
-108
| # TODO - we'll switch this to use templates in the future | ||
| # so keeping this simple with html/text the same |
Collaborator
Author
There was a problem hiding this comment.
By the time we use templates, we'll likely pivot entirely to a different email approach as Pinpoint is deprecated.
chouinar
commented
Dec 22, 2025
|
|
||
| # TODO add check_migrations_current to config | ||
| # if check_migrations_current: | ||
| # have_all_migrations_run(engine) |
Collaborator
Author
There was a problem hiding this comment.
The have_all_migrations_run function hasn't existed in years.
chouinar
commented
Dec 23, 2025
Collaborator
Author
There was a problem hiding this comment.
Note - this file was mistakenly created in the root directory and isn't in the API folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7636
Changes proposed
Remove/adjust many TODOs in the API code base
Context for reviewers
Just cleanup, I know many of these are resolved/not an issue as I wrote many of them myself. They fall into a few buckets:
A lot of these I wrote when the project went on hiatus last year and I had no one to consult with, and didn't know how certain elements would scale out. We know that now, no reason to leave them.
There are a few remaining TODOs that we'll make tickets for, I've put those on the linked issue, will follow up on those separately.