feat: disable fields for agreement edit form #4794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements field disabling functionality for the agreement edit form based on agreement status. When an agreement is awarded, certain fields (name, contract type, service requirement type, product service code, procurement shop, agreement reason, requesting agency, and servicing agency) become immutable and are visually disabled with explanatory tooltips. Super users retain the ability to edit these fields even on awarded agreements.
Key changes include:
- Backend logic to return immutable fields list based on agreement awarded status
- Frontend form components updated to support disabled states with tooltips
- Helper function to determine field disablement based on user role and field status
- Comprehensive E2E tests to verify field disabling behavior for regular users and super users
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/models/agreements.py | Added conditional logic to immutable_awarded_fields property to return empty list when agreement is not awarded |
| backend/ops_api/tests/ops/agreement/test_agreement_immutable_awarded_fields.py | Updated all tests to create awarded procurement actions before asserting immutable fields behavior |
| frontend/src/components/UI/Form/Input/Input.jsx | Added isDisabled and tooltipMsg props with conditional rendering for disabled state; removed PropTypes |
| frontend/src/components/UI/Form/Select/Select.jsx | Added isDisabled and tooltipMsg props with conditional rendering for disabled state and tooltip |
| frontend/src/components/UI/Form/ComboBox/ComboBox.jsx | Added isDisabled and tooltipMsg props with conditional rendering for disabled ComboBox |
| frontend/src/components/Agreements/ProductServiceCodeSelect.jsx | Added isDisabled and tooltipMsg props with conditional rendering for disabled select |
| frontend/src/components/Agreements/AgreementReasonSelect.jsx | Added isDisabled and tooltipMsg props with conditional rendering for disabled fieldset and select |
| frontend/src/components/ServicesComponents/ContractTypeSelect/ContractTypeSelect.jsx | Added isDisabled prop and removed PropTypes |
| frontend/src/components/ServicesComponents/ServiceReqTypeSelect/ServiceReqTypeSelect.jsx | Added isDisabled and tooltipMsg props and removed PropTypes |
| frontend/src/components/Agreements/AgencySelect/AgencySelect.jsx | Added isDisabled and tooltipMsg props to pass through to ComboBox |
| frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.jsx | Applied field disabling logic to all immutable awarded fields using isFieldDisabled helper |
| frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.hooks.js | Extracted immutable_awarded_fields from agreement metadata and added super user check to procurement shop disabling |
| frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.helpers.js | New helper file with isFieldDisabled function to determine field disablement based on field type, immutable fields list, and user role |
| frontend/src/pages/agreements/agreements.constants.js | Added Name field to AgreementFields enum |
| frontend/src/pages/agreements/details/AgreementDetailsEdit.test.js | Updated mock agreement data to include _meta.immutable_awarded_fields property |
| frontend/cypress/e2e/editAgreement.cy.js | Added comprehensive E2E tests for awarded agreement field disabling and super user override behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/components/Agreements/AgreementEditor/AgreementEditForm.helpers.js
Show resolved
Hide resolved
frontend/src/components/Agreements/ProductServiceCodeSelect.jsx
Outdated
Show resolved
Hide resolved
frontend/src/components/ServicesComponents/ContractTypeSelect/ContractTypeSelect.jsx
Outdated
Show resolved
Hide resolved
backend/ops_api/tests/ops/agreement/test_agreement_immutable_awarded_fields.py
Show resolved
Hide resolved
weimiao67
added
python
weimiao67
requested review from
Santi-3rd,
johndeange,
josbell,
rajohnson90 and
weimiao67
as code owners
rajohnson90
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
This PR implements field disabling functionality for the agreement edit form based on agreement status. When an agreement is awarded, certain fields (name, contract type, service requirement type, product service code, procurement shop, agreement reason, requesting agency, and servicing agency) become immutable and are visually disabled with explanatory tooltips. Super users retain the ability to edit these fields even on awarded agreements.
Key changes include:
Backend logic to return immutable fields list based on agreement awarded status
Frontend form components updated to support disabled states with tooltips
Helper function to determine field disablement based on user role and field status
Comprehensive E2E tests to verify field disabling behavior for regular users and super users
Issue
How to test
Definition of Done Checklist