Fix long browser filenames#718
Merged
Merged
Conversation
Closed
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715.
Overview
This PR fixes long filename handling in the Ultimate 64 browser when acting on FAT-backed entries.
User-visible failures before this change:
Mount DiskandRun Diskcould fail withOpening disk file failed.Renamecould fail withERROR: FILE DOESN'T EXIST.Bugs
BrowsableDirEntry::getName()converted browser action names through a fixed 64-byte buffer.FileInfo::generate_fat_name()did not guarantee NUL termination for direct FAT names.Fixes
BrowsableDirEntry::getName()without truncating them.FileInfo::generate_fat_name()always NUL-terminate direct-name output.FileSystem::walk_path()FAT-name scratch buffer and pass its full size intogenerate_fat_name()so shared path resolution handles long names end to end.Tests
Host unit / regression tests
make -C software/filemanager/tests temp-auto-cleanupGenerateFatNameKeepsLongDirectNamesFileManagerHandlesLongDirectNamesReal hardware / e2e verification
The following e2e test was performed against an Ultimate 64 Elite I.
It successfully demonstrates rename and mounting of filenames exceeding 64 chars, specifically the name
zzzz_long_filename_browser_regression_0123456789_0123456789_0123456789_0123456789.d64.Invocation:
./tools/io/filemanager/browser_long_filename_test.pyOutput: