Remove mmcs option for generate_steady_states_no_multiphase and fix a warning #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApoChal
reviewed
Dec 9, 2025
tests/sampling_no_multiphase.py
Outdated
Comment on lines
18
to
20
| def test_shape_and_non_zero(steady_states, testing_class): | ||
| testing_class.assertTrue( steady_states.shape[0] == 95 ) | ||
| testing_class.assertTrue( steady_states.shape[1] == 1000 ) |
There was a problem hiding this comment.
I would pass the number of rows and columns as input to this function, so that it could be used for other models as well.
ApoChal
approved these changes
Dec 9, 2025
|
Thanks @vissarion! I approved the PR and left one comment. |
vissarion
force-pushed
the
fix/mmcs_and_warning
branch
from
a4236f1 to
04e8376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove obsolete functionality and a deprecated warning.
First, eb25822 eliminates the MMCS option from both
apply_samplingandgenerate_steady_states_no_multiphase, simplifying the sampling interface and avoiding unsupported paths. The choice of mmcs is not relevant forapply_samplingsince the latter accepts a matrix of samples of fixed/known size while mmcs based on given ess generates a variable length matrix of samples.Second, a4236f1 removes a deprecated warning.