Skip to content

Test against PHP 8.5 #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goetas merged 2 commits into from
Dec 21, 2025
+36 −6
Merged

Test against PHP 8.5 #2426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71a83c
Test against PHP 8.5
W0rma Dec 20, 2025
c7a4615
Fix noop call of deprecated setAccessible() in PHP > 8.0
W0rma Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ jobs:
composer-flags: ""
can-fail: false
symfony-require: "6.4.*"
- php-version: "8.5"
composer-flags: ""
can-fail: false
symfony-require: "6.4.*"
- php-version: "8.3"
composer-flags: ""
can-fail: false
Expand Down Expand Up @@ -83,11 +87,21 @@ jobs:
can-fail: false
symfony-require: "7.4.*"
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later
- php-version: "8.5"
composer-flags: ""
can-fail: false
symfony-require: "7.4.*"
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later
- php-version: "8.4"
composer-flags: ""
can-fail: false
symfony-require: "8.0.*"
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later
- php-version: "8.5"
composer-flags: ""
can-fail: false
symfony-require: "8.0.*"
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later
- php-version: "8.3"
composer-flags: ""
can-fail: true # we don't want to fail the build if we are incompatible with the next (unstable) Symfony version
Expand All @@ -96,6 +110,10 @@ jobs:
composer-flags: ""
can-fail: true # we don't want to fail the build if we are incompatible with the next (unstable) Symfony version
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later
- php-version: "8.5"
composer-flags: ""
can-fail: true # we don't want to fail the build if we are incompatible with the next (unstable) Symfony version
remove-sensio-bundle: yes # SensioFrameworkExtraBundle is not compatible with Symfony 7.0 or later

env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
8 changes: 6 additions & 2 deletions Tests/Negotiation/FormatNegotiatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ public function testGetBestWithPreferExtension()

$reflectionClass = new \ReflectionClass(get_class($this->request));
$reflectionProperty = $reflectionClass->getProperty('pathInfo');
$reflectionProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$reflectionProperty->setAccessible(true);
}
$reflectionProperty->setValue($this->request, '/file.json');

// Without extension mime-type in Accept header
Expand All @@ -135,7 +137,9 @@ public function testGetBestWithPreferExtensionAndUnknownExtension()

$reflectionClass = new \ReflectionClass(get_class($this->request));
$reflectionProperty = $reflectionClass->getProperty('pathInfo');
$reflectionProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$reflectionProperty->setAccessible(true);
}
$reflectionProperty->setValue($this->request, '/file.123456789');

$this->request->headers->set('Accept', 'text/html, application/json');
Expand Down
8 changes: 6 additions & 2 deletions Tests/Request/RequestBodyParamConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,9 @@ public function testContextConfiguration()
];

$contextConfigurationMethod = new \ReflectionMethod($converter, 'configureContext');
$contextConfigurationMethod->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$contextConfigurationMethod->setAccessible(true);
}
$contextConfigurationMethod->invoke($converter, $context = new Context(), $options);

$expectedContext = new Context();
Expand Down Expand Up @@ -225,7 +227,9 @@ public function testValidatorOptionsGetter()
];

$validatorMethod = new \ReflectionMethod($converter, 'getValidatorOptions');
$validatorMethod->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$validatorMethod->setAccessible(true);
}
$this->assertEquals(['groups' => ['foo'], 'traverse' => true, 'deep' => false], $validatorMethod->invoke($converter, $options1));
$this->assertEquals(['groups' => false, 'traverse' => false, 'deep' => true], $validatorMethod->invoke($converter, $options2));
}
Expand Down
8 changes: 6 additions & 2 deletions Tests/View/ViewHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,9 @@ public function testSerializeNullDataValues($expected, $serializeNull)
$viewHandler->setSerializeNullStrategy($serializeNull);

$contextMethod = new \ReflectionMethod($viewHandler, 'getSerializationContext');
$contextMethod->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$contextMethod->setAccessible(true);
}

$view = new View();
$context = $contextMethod->invoke($viewHandler, $view);
Expand Down Expand Up @@ -384,7 +386,9 @@ public function testConfigurableViewHandlerInterface()
$viewHandler->setSerializeNullStrategy(true);

$contextMethod = new \ReflectionMethod($viewHandler, 'getSerializationContext');
$contextMethod->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$contextMethod->setAccessible(true);
}

$view = new View();
$context = $contextMethod->invoke($viewHandler, $view);
Expand Down