fix(download): include CoreML bundle internals for subPath repos (StyleTTS2 corruptedModel) - #821
Conversation
For subPath repos, files rode into the download via the .json/.model/.bin
metadata allowance even when their parent mlmodelc bundle was not in the
required-model patterns. That materializes such bundles almost completely
(weights are .bin) while dropping model.mil — the bundle then passes the
coremldata.bin existence check but fails CoreML load with 'Error in
reading the MIL network', and auto-recovery re-downloads the same hole.
Field case: StyleTTS2's bert_fp16_t{64,128,256} and sized diffusion
sampler buckets under iteration_3/compiled — the default variant declares
only the 8 unsized bundles, so any text long enough to route to a sized
bucket failed with corruptedModel. Reproduced with two fresh downloads;
the hosted HF files are complete.
Include any file under a .mlmodelc/ or .mlpackage/ inside the subPath so
bundles are taken all-or-nothing. Extracted the include closure to
ModelHub.repoIncludeRule for unit testing.
VAD Benchmark ResultsPerformance Comparison
Dataset Details
✅: Average F1-Score above 70% |
Speaker Diarization Benchmark ResultsSpeaker Diarization PerformanceEvaluating "who spoke when" detection accuracy
Diarization Pipeline Timing BreakdownTime spent in each stage of speaker diarization
Speaker Diarization Research ComparisonResearch baselines typically achieve 18-30% DER on standard datasets
Note: RTFx shown above is from GitHub Actions runner. On Apple Silicon with ANE:
🎯 Speaker Diarization Test • AMI Corpus ES2004a • 1049.0s meeting audio • 33.2s diarization time • Test runtime: 2m 18s • 07/25/2026, 05:25 PM EST |
ASR Benchmark Results ✅Status: All benchmarks passed Parakeet v3 (multilingual)
Parakeet v2 (English-optimized)
Streaming (v3)
Streaming (v2)
Streaming tests use 5 files with 0.5s chunks to simulate real-time audio streaming 25 files per dataset • Test runtime: 12m1s • 07/25/2026, 05:33 PM EST RTFx = Real-Time Factor (higher is better) • Calculated as: Total audio duration ÷ Total processing time Expected RTFx Performance on Physical M1 Hardware:• M1 Mac: ~28x (clean), ~25x (other) Testing methodology follows HuggingFace Open ASR Leaderboard |
Parakeet EOU Benchmark Results ✅Status: Benchmark passed Performance Metrics
Streaming Metrics
Test runtime: 3m34s • 07/25/2026, 05:34 PM EST RTFx = Real-Time Factor (higher is better) • Processing includes: Model inference, audio preprocessing, state management, and file I/O |
Supertonic3 Smoke Test ✅
Runtime: 0m26s Note: CI VMs lack a physical Neural Engine; the ANE-bucketed VectorEstimator falls back to CPU here. This validates download + variant resolution + synthesis, not ANE residency/perf. |
PocketTTS Smoke Test ✅
Runtime: 1m14s Note: PocketTTS uses CoreML MLState (macOS 15) KV cache + Mimi streaming state. CI VM lacks physical GPU — audio quality and performance may differ from Apple Silicon. |
Offline VBx Pipeline ResultsSpeaker Diarization Performance (VBx Batch Mode)Optimal clustering with Hungarian algorithm for maximum accuracy
Offline VBx Pipeline Timing BreakdownTime spent in each stage of batch diarization
Speaker Diarization Research ComparisonOffline VBx achieves competitive accuracy with batch processing
Pipeline Details:
🎯 Offline VBx Test • AMI Corpus ES2004a • 1049.0s meeting audio • 99.1s processing • Test runtime: 1m 49s • 07/25/2026, 05:40 PM EST |
Sortformer High-Latency Benchmark ResultsES2004a Performance (30.4s latency config)
Sortformer High-Latency • ES2004a • Runtime: 3m 1s • 2026-07-25T21:46:56.184Z |
Bug
For subPath repos, the repo-download include rule admits files via the
.json/.model/.binmetadata allowance even when their parent.mlmodelcbundle is not in the required-model patterns. A non-required bundle therefore gets materialized ~completely — its weights are.bin— whilemodel.milis dropped. The resulting bundle passes thecoremldata.binexistence check but fails CoreML load withError in reading the MIL network, and corrupt-model auto-recovery re-downloads the exact same hole.Field case
StyleTTS2 (
FluidInference/StyleTTS-2-coreml/iteration_3/compiled): the default variant declares only the 8 unsized bundles, sobert_fp16_t{64,128,256}.mlmodelcand the sizedfused_diffusion_sampler_fp16_t*buckets leaked in withoutmodel.mil. Any text long enough to route to a sized bucket failed withcorruptedModel("bert_fp16_t128.mlmodelc", …). Reproduced with two fresh downloads; verified the hosted HF files are complete (iteration_3/compiled/*/model.milall present) — curling the six missingmodel.milfiles into the cache immediately fixed synthesis at all text lengths (benchmarked 11–18× RTFx after repair).Fix
Treat CoreML bundles as all-or-nothing: include any file under a
.mlmodelc/or.mlpackage/within the subPath. This only adds small files for bundles that were already being ~fully downloaded via the metadata allowance.Extracted the inline include closure to
ModelHub.repoIncludeRule(subPath:patterns:)and added unit tests (ModelHubIncludeRuleTests): the model.mil regression case, unchanged metadata/pattern/traversal behavior, and the no-subPath path.swift build+swift format lintclean locally; relying on CI for the test run.🤖 Generated with Claude Code