Update minimum Node.js version to 20.x #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Node 18 from CI matrix (EOL) - Add Node 24 and 26 to CI matrix - Update engines.node to >=20.x in package.json - Update @types/node resolution to ^20.0.0 - Add Requirements section to README Co-Authored-By: Claude Opus 4.5 <[email protected]>
Node 26 is not released yet. Use 20, 22, 23, 24 instead. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Keep only LTS versions: 20, 22, 24. Co-Authored-By: Claude Opus 4.5 <[email protected]>
aarsilv
commented
Jan 27, 2026
| export { EppoAssignmentLogger } | ||
|
|
||
| // @public | ||
| export function getBanditsConfiguration(): string; |
Contributor
Author
There was a problem hiding this comment.
guess auto generated API didn't make it in an earlier PR
| strategy: | ||
| matrix: | ||
| node-version: [ '18', '20', '22', '23' ] | ||
| node-version: [ '20', '22', '24' ] |
Contributor
Author
There was a problem hiding this comment.
bumping to all LTS versions
aarsilv
commented
Jan 27, 2026
Comment on lines
+11
to
+17
| - Dynamic configuration | ||
| - Progressive rollouts | ||
| - A/B/n experiments | ||
| - Holdouts | ||
| - Mutually exclusive experiments (Layers) | ||
| - Dynamic configuration | ||
| - Switchback experiments | ||
| - Contextual Multi-armed bandits |
Contributor
Author
There was a problem hiding this comment.
Add some more bragging while in here!
|
|
||
| ## Requirements | ||
|
|
||
| - Node.js version 20.x or later |
Contributor
Author
There was a problem hiding this comment.
Document our minimum version in README
BREAKING CHANGE: Minimum Node.js version is now 20.x (was 18.x). Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add generated docs for getFlagsConfiguration, getBanditsConfiguration, offlineInit, and IOfflineClientConfig - Configure .gitattributes to enforce LF line endings for docs - Set api-extractor newlineKind to lf Co-Authored-By: Claude Opus 4.5 <[email protected]>
aarsilv
commented
Jan 27, 2026
| </td></tr> | ||
| </tbody></table> | ||
| <!-- Do not edit this file. It is automatically generated by API Documenter. --> |
Contributor
Author
There was a problem hiding this comment.
Docs autogenerated updated not sure why git thinks this particular change is a diff
| @@ -1 +1,2 @@ | |||
| *.json linguist-language=JSON-with-Comments | |||
| docs/*.md text eol=lf | |||
Contributor
Author
There was a problem hiding this comment.
standardize line endings for autogenerated docs (and other files)
| * DEFAULT VALUE: "crlf" | ||
| */ | ||
| // "newlineKind": "crlf", | ||
| "newlineKind": "lf", |
| { | ||
| "name": "@eppo/node-server-sdk", | ||
| "version": "3.13.0", | ||
| "version": "4.0.0", |
Contributor
Author
There was a problem hiding this comment.
Major version bump since supported engines changed
greghuels
approved these changes
Jan 27, 2026
Contributor
|
You'll want to update js-sdk-common as well |
leoromanovsky
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal
🎟️ Ticket: FFESUPPORT-478 - Update Node Server SDK minimum supported node version to 20
Motivation and Context
One of the dependencies updated to address a security vulnerability requires Node Version 20 or higher. Also, version 18 hit end of life in April 2025.
Description
Update minimum supported node version to 20 including our testing matrix, imported types, and documentation.
How has this been documented?
Updated README
How has this been tested?
Existing automated tests