Offline Init Part 2 of 4: Add getBanditsConfiguration() to export bandit models as JSON #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part2-get-bandits-configuration
branch
2 times, most recently
from
5c56e10 to
eae1ff4
Compare
This was referenced Jan 20, 2026
Merged
aarsilv
changed the title
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part2-get-bandits-configuration
branch
2 times, most recently
from
7396a8f to
128bac6
Compare
aarsilv
commented
Jan 20, 2026
src/index.ts
Outdated
Comment on lines
276
to
268
| const configuration: { | ||
| bandits: Record<string, BanditParameters>; | ||
| } = { | ||
| bandits, | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This is simpler than the original flag configuration because we basically store bandit configurations (model parameters) as-is
There was a problem hiding this comment.
Pull request overview
This PR adds getBanditsConfiguration() to export bandit model configurations as JSON, complementing the existing getFlagsConfiguration() for offline SDK initialization.
Changes:
- Adds
getBanditsConfiguration()function that serializes bandit models to JSON - Includes comprehensive tests validating the JSON structure against bandit-models-v1.json
- Updates GitHub Actions workflow to use
**branch pattern instead of*
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Adds getBanditsConfiguration() function to export bandit models as JSON |
| src/index.spec.ts | Adds tests for getBanditsConfiguration() including null cases and structure validation |
| .github/workflows/lint-test-sdk.yml | Updates branch pattern from * to ** for pull request triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/index.ts
Outdated
Comment on lines
264
to
270
| export function getBanditsConfiguration(): string | null { | ||
| if (!banditModelConfigurationStore) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
The early return when banditModelConfigurationStore is not initialized lacks test coverage. Add a test case that calls getBanditsConfiguration() before init() to verify it returns null.
aarsilv
commented
Jan 20, 2026
| on: | ||
| pull_request: | ||
| branches: [ "*" ] | ||
| branches: [ "**" ] |
Contributor
Author
There was a problem hiding this comment.
still apply if merging into branches with slashes in their name
greghuels
approved these changes
Jan 20, 2026
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part2-get-bandits-configuration
branch
2 times, most recently
from
b235e30 to
c35ea62
Compare
Base automatically changed from
aarsilv/ffesupport-461-offline-init-part1-get-flags-configuration
to
main
January 27, 2026 00:10
This function returns the current bandits configuration as a JSON string that can be used together with getFlagsConfiguration() to bootstrap another SDK instance. Returns null if no bandits are configured. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Fixes test isolation issue where tests ran after API server was closed. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Verify exact structure from bandit-models-v1.json including: - Exact number of bandits (3) - Specific bandit keys (banner_bandit, car_bandit, cold_start_bandit) - Detailed banner_bandit structure verification - Different settings for car_bandit and cold_start_bandit Co-Authored-By: Claude Opus 4.5 <[email protected]>
Change branches pattern from "*" to "**" so the workflow triggers for PRs targeting branches like "aarsilv/feature-name" (stacked PRs). The single asterisk doesn't match "/" characters in GitHub Actions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add BanditsConfigurationResponse interface matching IBanditParametersResponse structure from the common package (with updatedAt optional since not stored) - Update getBanditsConfiguration() to use the typed interface This ensures consistency with getFlagsConfiguration() and provides better type safety for the export/import workflow. Co-Authored-By: Claude Opus 4.5 <[email protected]>
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part2-get-bandits-configuration
branch
from
291bc6f to
f3ee984
Compare
aarsilv
deleted the
aarsilv/ffesupport-461-offline-init-part2-get-bandits-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getBanditsConfiguration()function to export bandit models as JSONgetFlagsConfiguration()for complete offline initialization supportStacked PRs
getFlagsConfiguration()getBanditsConfiguration()(this PR)offlineInit()Test plan
getBanditsConfiguration()returns null before initialization🤖 Generated with Claude Code