Adds new ocean to ice coupling fields for frazil ice formation #460
Draft
njeffery wants to merge 10 commits into
Draft
Adds new ocean to ice coupling fields for frazil ice formation #460njeffery wants to merge 10 commits into
njeffery wants to merge 10 commits into
Conversation
Updates Icepack submodule to frazil coupling branch Adds ocean-ice coupling fields: frazil salt flux (Fioo_frazils) frazil enthalpy flux (Fioo_frazilh) defined consistent with freezingMeltPotential To use, set config_frazil_coupling_type to ‘omega-fluxes’ Backwards compatible with mpas-ocean for config_frazil_coupling_type = ‘external’ Stealth
Sea ice initialize now allows for the config_frazil_coupling_type option: "omega-fluxes"
Sea ice initialize NOW allows for config_frazil_coupling_type option: “omega-fluxes”
Removes double counting of frazil energy in coupler budget. Corrects possible but in temperature tendency of frazil melt. nBFB
Adds optional formulation in frazil.
Revert to original formulation with comments.
njeffery
requested review from
alicebarthel,
darincomeau,
erinethomas,
karapeterson and
proteanplanet
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for the ocean model to compute the accumulated frazil mass, salt mass, and energy,
and passes to the sea ice model If mpas-seaice option, config_frazil_coupling_type = “omega-fluxes”.
Fioo_Frazils – total accumulated frazil salt mass per time
Fioo_Frazilh – total accumulated frazil energy per time (defined as positive to be consistent with ‘q’ the sea ice potential)
The new implementation has a requirement that the new frazil salinity be greater than 0.1 ppt.
Works with icepack https://github.com/E3SM-Project/Icepack/tree/njeffery/omega-coupling-frazil in E3SM-Project/Icepack#43
Includes updates from @erinethomas and @karapeterson (https://github.com/erinethomas/E3SM/tree/omega/ice-coupling)
Tested in mpas-ocean and confirmed BFB for default config_frazil_coupling_type = “external”
Stealth.