Make OMEGA_LOG_TASKS a runtime environment variable#429
Open
grnydawn wants to merge 1 commit into
Open
Conversation
…ile-time CMake option.
Collaborator
|
Passes CTests on Frontier for CPU and GPU. |
Collaborator
|
@andrewdnolan, if you have time to review/approve it would be nice to get this one merged. |
andrewdnolan
approved these changes
Jul 8, 2026
andrewdnolan
left a comment
There was a problem hiding this comment.
Testing:
In order to test this in the most realistic setting possible, I cherry picked the one commit from this branch onto my coupled-driver branch and set up a case where the ROOTPE_OCN was no-zero. These are the commands I ran:
CASE_DIR=$PSCRATCH/E3SMv3/omega-logging-test
./create_newcase \
-case ${CASE_DIR} \
-mach pm-gpu \
-res T62_oQU240 \
--compset COMEGA-JRA1p4
pushd $CASE_DIR
./xmlchange DEBUG=true
./xmlchange ROOTPE_OCN=3
./case.setup
./case.build
salloc --nodes 2 --qos interactive --time 00:15:00 --gpus-per-node 4 --constraint gpu --account e3sm_g
./case.submit --no-batch
grep "^3: (seq_comm_setcomm)" /pscratch/sd/a/anolan/e3sm_scratch/pm-gpu/omega-logging-test/run/e3sm.log.55687647.260708-110043Which returns:
3: (seq_comm_setcomm) init ID ( 17 OCN ) pelist = 3 6 1 ( npes = 4) ( nthreads = 1)( suffix =)
And then there's a ocn.log... file with the output I'd expect!
cat /pscratch/sd/a/anolan/e3sm_scratch/pm-gpu/omega-logging-test/run/ocn.log.55687647.260708-110043 | wc -l
# 7
@grnydawn Sorry this took so long to get around to, but this looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
OMEGA_LOG_TASKSas a compile-time CMake option with a runtime environment variable for log task selection.This feature was requested for integration with E3SM. It also allows users to change the MPI tasks that generate log files without rebuilding the Omega executable.
Testing passed on Perlmutter.
Checklist