test: add unit tests for LogEntrytAdmin.get_search_results #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests cover: - Searching with 'ID123' format (uppercase) - Searching with 'id123' format (lowercase) - Searching by object_id - Searching by change_message content - Empty search term behavior - Non-matching change_message Closes DjangoCRM#355
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the get_search_results method in the LogEntrytAdmin class (note: this class name contains a typo - it should be LogEntryAdmin). The tests verify various search patterns including uppercase/lowercase ID prefixes, object ID searches, change message searches, empty search terms, and non-matching scenarios.
Key Changes
- Added 6 test methods covering different search patterns for the admin interface
- Tests verify ID-based searches (e.g., 'ID123', 'id123'), object_id searches, and change_message content searches
- Includes edge case testing for empty search terms and non-matching queries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@adityashirsatrao007 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the \get_search_results\ method in the \LogEntrytAdmin\ class.
Tests Added
Testing
\
python manage.py test tests.common.test_log_entry_admin --keepdb
\\
Closes #355