Use classes with readonly properties more widely#1592
Open
bpfoley wants to merge 12 commits into
Open
Conversation
cpeel
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more intended to start discussion rather than necessarily to be merged as-is.
As you can see, PHP 8.0's "property constructor promotion" is more of a win in simpler classes that are mostly "data transfer objects", and it saves less boilerplate when there's an inheritance hierarchy, or when some properties have to be explicitly declared.
However, I do like the opportunity to sprinkle more 'readonly' on properties (which says only the constructor can assign to a property, and it can only do it once). Avoiding mutable state makes it a lot easier to reason about classes.
After a couple of fixes, it passes all the smoke tests (and PHPstan is happy).
It's deployed at https://www.pgdp.org/~bfoley/c.branch/more-dto and I did some cursory poking around with the proofreading interface, project search, wordcheck, stats etc.