Fix aspect ratio not propagated to separate plot windows

Closes #287

Author: PierreRaybaut

datalab/gui/plothandler.py

@@ -810,4 +810,9 @@ def get_plot_options(self) -> PlotOptions:
         options = super().get_plot_options()
         options.zlabel = self.plot.get_axis_title("right")
         options.zunit = self.plot.get_axis_unit("right")
+        # Include aspect ratio configuration so that separate plot dialogs
+        # (e.g. "View in a new window", ROI editors, profile dialogs) use the same
+        # settings as the integrated plot handler:
+        options.aspect_ratio = self.plot.get_aspect_ratio()
+        options.lock_aspect_ratio = self.plot.lock_aspect_ratio
         return options

datalab/gui/processor/image.py

@@ -779,7 +779,8 @@ def create_roi_grid(self) -> None:
                 == QW.QMessageBox.No
             ):
                 return
-        editor = ImageGridROIEditor(parent=self.parent(), obj=obj0)
+        options = self.panel.plothandler.get_plot_options()
+        editor = ImageGridROIEditor(parent=self.parent(), obj=obj0, options=options)
         if exec_dialog(editor):
             for obj in self.panel.objview.get_sel_objects():
                 obj.roi = editor.get_roi()
@@ -1014,7 +1015,10 @@ def compute_offset_correction(self, param: ROI2DParam | None = None) -> None:
         with :py:func:`sigima.proc.image.offset_correction`"""
         obj = self.panel.objview.get_sel_objects(include_groups=True)[0]
         if param is None:
-            dlg = imagebackground.ImageBackgroundDialog(obj, parent=self.mainwindow)
+            options = self.panel.plothandler.get_plot_options()
+            dlg = imagebackground.ImageBackgroundDialog(
+                obj, parent=self.mainwindow, options=options
+            )
             if exec_dialog(dlg):
                 x0, y0, x1, y1 = dlg.get_rect_coords()
                 param = ROI2DParam.create(

datalab/widgets/imagebackground.py

@@ -6,12 +6,12 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
 import numpy as np
 from guidata.configtools import get_icon
 from plotpy.builder import make
-from plotpy.plot import PlotDialog
+from plotpy.plot import PlotDialog, PlotOptions
 
 from datalab.adapters_plotpy import create_adapter_from_object
 from datalab.config import _
@@ -29,16 +29,25 @@ class ImageBackgroundDialog(PlotDialog):
     Args:
         image: image object
         parent: parent widget. Defaults to None.
+        options: plot options. Defaults to None.
     """
 
-    def __init__(self, image: ImageObj, parent: QWidget | None = None) -> None:
+    def __init__(
+        self,
+        image: ImageObj,
+        parent: QWidget | None = None,
+        options: PlotOptions | dict[str, Any] | None = None,
+    ) -> None:
         self.__background: float | None = None
         self.__rect_coords: tuple[float, float, float, float] | None = None
         self.imageitem: MaskedXYImageItem | None = None
         self.rectarea: RectangleShape | None = None
         self.comput2d: RangeComputation2d | None = None
         super().__init__(
-            title=_("Image background selection"), edit=True, parent=parent
+            title=_("Image background selection"),
+            edit=True,
+            parent=parent,
+            options=options,
         )
         self.setObjectName("backgroundselection")
         if parent is None:

doc/locale/fr/LC_MESSAGES/release_notes/release_1.00.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: DataLab \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-12-16 12:43+0100\n"
+"POT-Creation-Date: 2025-12-16 14:35+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -27,6 +27,21 @@ msgstr ""
 msgid "🛠️ Bug Fixes since version 1.0.2"
 msgstr "🛠️ Correctifs depuis la version 1.0.2"
 
+msgid "**Separate plot windows - Incorrect aspect ratio for non-uniform coordinates:**"
+msgstr "**Fenêtres de tracé séparées - Rapport d'aspect incorrect pour les coordonnées non uniformes :**"
+
+msgid "Fixed separate plot windows (e.g., \"View in a new window\", ROI editors, profile dialogs) not using the same aspect ratio configuration as the integrated plot handler"
+msgstr "Correction des fenêtres de tracé séparées (par ex. « Voir dans une nouvelle fenêtre », éditeurs de ROI, dialogues de profil) qui n'utilisaient pas la même configuration de rapport d'aspect que le gestionnaire de tracé intégré"
+
+msgid "When displaying images with non-uniform coordinates, the main plot correctly unlocks the aspect ratio for proper display, but separate windows were not inheriting this setting"
+msgstr "Lors de l'affichage d'images avec des coordonnées non uniformes, le tracé principal déverrouille correctement le rapport d'aspect pour un affichage approprié, mais les fenêtres séparées n'héritaient pas de ce paramètre"
+
+msgid "All image dialogs now properly inherit the aspect ratio settings, ensuring consistent display behavior across all plot windows"
+msgstr "Toutes les boîtes de dialogue d'image héritent désormais correctement des paramètres de rapport d'aspect, assurant un comportement d'affichage cohérent sur toutes les fenêtres de tracé"
+
+msgid "This closes [Issue #287](https://github.com/DataLab-Platform/DataLab/issues/287) - Separate plot windows don't use same aspect ratio configuration as integrated plot"
+msgstr "Ceci clôture [Issue #287](https://github.com/datalab-platform/datalab/issues/287) - Separate plot windows don't use same aspect ratio configuration as integrated plot"
+
 msgid "**Remove all results - AttributeError when ROI was removed:**"
 msgstr "**Supprimer tous les résultats - AttributeError lorsque la ROI a été supprimée :**"
 
@@ -48,7 +63,8 @@ msgstr "Tentative de suppression de tous les résultats via « Analyse > Supprim
 msgid "The fix adds a proper None check before accessing the ROI's title"
 msgstr "Le correctif ajoute une vérification de valeur None appropriée avant d'accéder au titre de la ROI"
 
-msgid "This closes [Issue #286](https://github.com/DataLab-Platform/DataLab/issues/286) - 'Remove all results' fails with AttributeError when ROI was removed"
+#, fuzzy
+msgid "This closes [Issue #286](https://github.com/DataLab-Platform/DataLab/issues/286) - \"Remove all results\" fails with AttributeError when ROI was removed"
 msgstr "Ceci clôture [Issue #286](https://github.com/datalab-platform/datalab/issues/286) - 'Remove all results' fails with AttributeError when ROI was removed"
 
 msgid "**Analysis auto-recompute - Stale parameters after deleting results:**"

doc/release_notes/release_1.00.md

@@ -4,6 +4,13 @@
 
 ### 🛠️ Bug Fixes since version 1.0.2 ###
 
+**Separate plot windows - Incorrect aspect ratio for non-uniform coordinates:**
+
+* Fixed separate plot windows (e.g., "View in a new window", ROI editors, profile dialogs) not using the same aspect ratio configuration as the integrated plot handler
+* When displaying images with non-uniform coordinates, the main plot correctly unlocks the aspect ratio for proper display, but separate windows were not inheriting this setting
+* All image dialogs now properly inherit the aspect ratio settings, ensuring consistent display behavior across all plot windows
+* This closes [Issue #287](https://github.com/DataLab-Platform/DataLab/issues/287) - Separate plot windows don't use same aspect ratio configuration as integrated plot
+
 **Remove all results - AttributeError when ROI was removed:**
 
 * Fixed "Remove all results" action failing with `AttributeError: 'NoneType' object has no attribute 'get_single_roi_title'` when results contain ROI information but the ROI was subsequently removed from the object