Fix "Remove all results" AttributeError when ROI was removed

Closes #286

Author: PierreRaybaut

datalab/adapters_metadata/common.py

@@ -88,7 +88,7 @@ def append(self, adapter: BaseResultAdapter, obj: SignalObj | ImageObj) -> None:
             if "roi_index" in df.columns:
                 i_roi = int(df.iloc[i_row_res]["roi_index"])
                 roititle = ""
-                if i_roi >= 0:
+                if i_roi >= 0 and obj.roi is not None:
                     roititle = obj.roi.get_single_roi_title(i_roi)
                     ylabel += f"|{roititle}"
             self.ylabels.append(ylabel)

datalab/tests/features/common/result_deletion_unit_test.py

@@ -154,7 +154,63 @@ def test_delete_results_clears_analysis_parameters():
         execenv.print("\n✓ All tests passed!")
 
 
+def test_delete_results_after_roi_removed():
+    """Test that deleting results works when ROI was removed from object.
+
+    This tests the fix for the bug where deleting results fails with
+    AttributeError when results contain ROI information but the ROI
+    was subsequently removed from the object.
+    """
+    with datalab_test_app_context(console=False) as win:
+        execenv.print("Test delete_results after ROI removed:")
+        panel = win.imagepanel
+
+        # Create a test image with ROI
+        param = Gauss2DParam.create(height=200, width=200, sigma=20)
+        img = create_image_from_param(param)
+        roi = create_image_roi("rectangle", [25, 25, 100, 100])
+        img.roi = roi
+        panel.add_object(img)
+        execenv.print("  ✓ Created image with ROI")
+
+        # Run centroid analysis - this stores ROI index in results
+        execenv.print("  Running centroid analysis with ROI...")
+        with Conf.proc.show_result_dialog.temp(False):
+            panel.processor.run_feature("centroid")
+
+        # Verify that results exist and contain ROI information
+        img_refreshed = panel.objmodel[get_uuid(img)]
+        adapter_before = GeometryAdapter.from_obj(img_refreshed, "centroid")
+        assert adapter_before is not None, "Centroid result should exist"
+        df = adapter_before.to_dataframe()
+        assert "roi_index" in df.columns, "Results should contain roi_index"
+        execenv.print("  ✓ Centroid result created with ROI information")
+
+        # Now remove the ROI from the object (simulating user action)
+        img_refreshed.roi = None
+        execenv.print("  ✓ Removed ROI from object")
+
+        # Try to delete all results - this should NOT raise an error
+        execenv.print("  Deleting all results (with ROI removed)...")
+        panel.objview.select_objects([get_uuid(img)])
+        try:
+            panel.delete_results()
+            execenv.print("  ✓ Delete results succeeded (no AttributeError)")
+        except AttributeError as e:
+            raise AssertionError(
+                f"delete_results should not raise AttributeError when ROI is None: {e}"
+            ) from e
+
+        # Verify that results were deleted
+        img_after = panel.objmodel[get_uuid(img)]
+        adapter_after = GeometryAdapter.from_obj(img_after, "centroid")
+        assert adapter_after is None, "Centroid result should be deleted"
+        execenv.print("  ✓ Centroid result deleted successfully")
+        execenv.print("\n✓ Test passed!")
+
+
 if __name__ == "__main__":
     test_delete_results_image()
     test_delete_results_signal()
     test_delete_results_clears_analysis_parameters()
+    test_delete_results_after_roi_removed()

doc/locale/fr/LC_MESSAGES/release_notes/release_1.00.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: DataLab \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-12-16 10:56+0100\n"
+"POT-Creation-Date: 2025-12-16 12:43+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -27,6 +27,30 @@ msgstr ""
 msgid "🛠️ Bug Fixes since version 1.0.2"
 msgstr "🛠️ Correctifs depuis la version 1.0.2"
 
+msgid "**Remove all results - AttributeError when ROI was removed:**"
+msgstr "**Supprimer tous les résultats - AttributeError lorsque la ROI a été supprimée :**"
+
+msgid "Fixed \"Remove all results\" action failing with `AttributeError: 'NoneType' object has no attribute 'get_single_roi_title'` when results contain ROI information but the ROI was subsequently removed from the object"
+msgstr "Correction de l'action « Supprimer tous les résultats » qui échouait avec `AttributeError: 'NoneType' object has no attribute 'get_single_roi_title'` lorsque les résultats contiennent des informations de ROI mais que la ROI a été ensuite supprimée de l'objet"
+
+msgid "The issue occurred when:"
+msgstr "Le problème se produisait lorsque :"
+
+msgid "Running an analysis with a ROI (e.g., Centroid on an image with rectangular ROI)"
+msgstr "Exécution d'une analyse avec une ROI (par ex. Centroïde sur une image avec ROI rectangulaire)"
+
+msgid "Removing the ROI from the object"
+msgstr "Suppression de la ROI de l'objet"
+
+msgid "Trying to delete all results via \"Analysis > Remove results > Remove all results\""
+msgstr "Tentative de suppression de tous les résultats via « Analyse > Supprimer les résultats > Supprimer tous les résultats »"
+
+msgid "The fix adds a proper None check before accessing the ROI's title"
+msgstr "Le correctif ajoute une vérification de valeur None appropriée avant d'accéder au titre de la ROI"
+
+msgid "This closes [Issue #286](https://github.com/DataLab-Platform/DataLab/issues/286) - 'Remove all results' fails with AttributeError when ROI was removed"
+msgstr "Ceci clôture [Issue #286](https://github.com/datalab-platform/datalab/issues/286) - 'Remove all results' fails with AttributeError when ROI was removed"
+
 msgid "**Analysis auto-recompute - Stale parameters after deleting results:**"
 msgstr "**Recalcul automatique de l'analyse - Paramètres obsolètes après suppression des résultats :**"
 

doc/release_notes/release_1.00.md

@@ -4,6 +4,16 @@
 
 ### 🛠️ Bug Fixes since version 1.0.2 ###
 
+**Remove all results - AttributeError when ROI was removed:**
+
+* Fixed "Remove all results" action failing with `AttributeError: 'NoneType' object has no attribute 'get_single_roi_title'` when results contain ROI information but the ROI was subsequently removed from the object
+* The issue occurred when:
+  1. Running an analysis with a ROI (e.g., Centroid on an image with rectangular ROI)
+  2. Removing the ROI from the object
+  3. Trying to delete all results via "Analysis > Remove results > Remove all results"
+* The fix adds a proper None check before accessing the ROI's title
+* This closes [Issue #286](https://github.com/DataLab-Platform/DataLab/issues/286) - "Remove all results" fails with AttributeError when ROI was removed
+
 **Analysis auto-recompute - Stale parameters after deleting results:**
 
 * Fixed analysis parameters not being cleared when deleting analysis results, which could cause unexpected auto-recompute behavior when modifying ROIs