[golang] Mark test_waf_monitoring_errors as irrelevant #6191
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test validates WAF monitoring span tags that were deprecated by RFC-1025: - _dd.appsec.event_rules.loaded - _dd.appsec.event_rules.error_count - _dd.appsec.event_rules.errors The Jira ticket LANGPLAT-584 was marked as 'Won't Do' since this is not a bug in the Go tracer - the functionality was intentionally deprecated. This aligns Go's manifest with Ruby and Node.js, which already mark this test as irrelevant for the same reason. Co-Authored-By: Romain Marcadier <[email protected]> JJ-Change-Id: mtxomp
Contributor
|
|
eliottness
approved these changes
Feb 3, 2026
eliottness
deleted the
romain.marcadier/LANGPLAT-584/mark-waf-monitoring-errors-irrelevant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
test_waf_monitoring_errorsasirrelevantinstead ofbugin Go manifest.The test validates WAF monitoring span tags that were deprecated by RFC-1025:
_dd.appsec.event_rules.loaded_dd.appsec.event_rules.error_count_dd.appsec.event_rules.errorsThis aligns Go's manifest with Ruby and Node.js, which already mark this test as irrelevant for the same reason.
Fixes: LANGPLAT-584
Co-Authored-By: Claude Opus 4.5 [email protected]