Skip to content

Conversation

@daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Jan 29, 2026

Motivation

Needs V3.37.0 (next release)

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@daniel-romano-DD daniel-romano-DD requested review from a team as code owners January 29, 2026 16:44
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
tests/appsec/waf/test_telemetry.py                                      @DataDog/asm-libraries @DataDog/system-tests-core

@datadog-official
Copy link

datadog-official bot commented Jan 29, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 2 Tests failed

tests.appsec.waf.test_truncation.Test_Truncation.test_truncation[poc] from system_tests_suite (Datadog) (Fix with Cursor)
KeyError: '_dd.appsec.truncated.string_length'

self = <tests.appsec.waf.test_truncation.Test_Truncation object at 0x7f5370b2d1f0>

    def test_truncation(self):
        span = interfaces.library.get_root_span(self.req)
        metrics = span.get("metrics")
        assert metrics, "Expected metrics"
    
>       assert int(metrics["_dd.appsec.truncated.string_length"]) == 5000
...
tests.appsec.waf.test_truncation.Test_Truncation.test_truncation[uds] from system_tests_suite (Datadog) (Fix with Cursor)
KeyError: '_dd.appsec.truncated.string_length'

self = <tests.appsec.waf.test_truncation.Test_Truncation object at 0x7fbb8deebcb0>

    def test_truncation(self):
        span = interfaces.library.get_root_span(self.req)
        metrics = span.get("metrics")
        assert metrics, "Expected metrics"
    
>       assert int(metrics["_dd.appsec.truncated.string_length"]) == 5000
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a7f277a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@daniel-romano-DD daniel-romano-DD marked this pull request as draft January 29, 2026 17:28
@daniel-romano-DD daniel-romano-DD added the dotnet Pull requests that update .NET code label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants