Skip to content

Migrate SSI Appsec test definitions from decorators to manifest files #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avara1986 merged 11 commits into from
Feb 2, 2026
Merged

Migrate SSI Appsec test definitions from decorators to manifest files #6134

avara1986 merged 11 commits into from
Feb 2, 2026
+42 −17

Conversation

@avara1986
Copy link
Member

@avara1986 avara1986 commented Jan 28, 2026

Migrates the test activation/deactivation logic for SSI and auto-inject Appsec tests from decorators to language manifest files. This aligns with the system-tests best practice of managing language-specific test configurations in manifest files rather than in-line decorators

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

CODEOWNERS have been resolved as:

manifests/cpp_nginx.yml                                                 @DataDog/system-tests-core
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
manifests/rust.yml                                                      @DataDog/apm-rust
tests/auto_inject/test_auto_inject_install.py                           @DataDog/system-tests-core
tests/docker_ssi/test_docker_ssi_appsec.py                              @DataDog/system-tests-core

@avara1986 avara1986 marked this pull request as ready for review January 30, 2026 10:08
@avara1986 avara1986 requested review from a team as code owners January 30, 2026 10:08
@avara1986 avara1986 requested review from christophe-papazian, jandro996 and juanjux and removed request for a team January 30, 2026 10:08
cbeauchesne
cbeauchesne reviewed Jan 30, 2026
View reviewed changes
tests/auto_inject/test_auto_inject_install.py Outdated
@irrelevant(
context.library > "[email protected]" and context.installed_language_runtime < "3.9.0",
reason="python 3.8 is not supported on ddtrace >= 3.x",
context.library == "python" and context.installed_language_runtime < "3.9.0", reason="Python 3.9+ required"
Copy link
Collaborator

@cbeauchesne cbeauchesne Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertomonteromiguel if we are not testing anymore python version lower than 3.9, would it possible to simply remove those from the test matrix used in CI ?

Copy link
Member Author

@avara1986 avara1986 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python tracer dropped support for Python 3.8 starting with tracer version 4.0, but there are still many clients using 3.x versions of the tracer, so I’m not sure whether we should keep some tests for 3.8 just in case?

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still being triggered for the Python tracer 2.x and 3.x branches. I think we should add a condition here to ensure the tests also pass for those branches.

Copy link
Member Author

@avara1986 avara1986 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated with your suggestions ;)

robertomonteromiguel
robertomonteromiguel requested changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the decorators part for the Python tracer 2.x/3.x branches needs attention. Everything else LGTM.

tests/auto_inject/test_auto_inject_install.py Outdated
@irrelevant(
context.library > "[email protected]" and context.installed_language_runtime < "3.9.0",
reason="python 3.8 is not supported on ddtrace >= 3.x",
context.library == "python" and context.installed_language_runtime < "3.9.0", reason="Python 3.9+ required"
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still being triggered for the Python tracer 2.x and 3.x branches. I think we should add a condition here to ensure the tests also pass for those branches.

@avara1986 avara1986 merged commit 36ce3e5 into main Feb 2, 2026
1949 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-60926_restructure_appsec_ssi_tests branch February 2, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne left review comments

@robertomonteromiguel robertomonteromiguel robertomonteromiguel approved these changes

@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-python

@christophe-papazian christophe-papazian Awaiting requested review from christophe-papazian christophe-papazian is a code owner automatically assigned from DataDog/apm-python

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@daniel-romano-DD daniel-romano-DD Awaiting requested review from daniel-romano-DD daniel-romano-DD is a code owner automatically assigned from DataDog/asm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avara1986 @cbeauchesne @robertomonteromiguel