-
Notifications
You must be signed in to change notification settings - Fork 14
test: add dd-trace without OpenFeature system test #6119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leoromanovsky
wants to merge
7
commits into
main
Choose a base branch
from
leo/test-ddtrace-without-openfeature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
8164a91 to
0a9ce87
Compare
|
177b1ae to
524034a
Compare
This was referenced Jan 27, 2026
Merged
Add a new weblog variant (express4-no-openfeature) and test to validate that dd-trace works correctly when OpenFeature SDK is not installed. This validates the fix for DataDog/dd-trace-js#6986 Refs: DataDog/dd-trace-js#6986
524034a to
39940a1
Compare
- Add /healthcheck endpoint returning library info JSON - Add /flush endpoint for trace flushing - Update manifest from 6.0.0-pre to >=5.75.0 (test passes now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a system test to verify that dd-trace works correctly when the OpenFeature SDK is not installed. This validates the fix for DataDog/dd-trace-js#6986
Users of dd-trace who don't use OpenFeature were encountering peer dependency errors. This test ensures dd-trace initializes and runs correctly at runtime without OpenFeature packages.
Changes
New Files
utils/build/docker/nodejs/express4-no-openfeature.Dockerfile: New weblog variant that installs dd-trace then removes OpenFeature packagesutils/build/docker/nodejs/express/app-no-openfeature.js: Minimal app with required system-tests endpointstests/openfeature/test_ddtrace_without_openfeature.py: Test verifying dd-trace works without OpenFeaturetests/openfeature/__init__.py: Package initModified Files
manifests/*.yml: Added manifest entries marking test as irrelevant for all weblogs exceptexpress4-no-openfeatureTest Coverage
The test validates that dd-trace initializes successfully and the weblog responds to requests when OpenFeature packages are not installed. The key assertion is that the root endpoint returns 200, proving dd-trace didn't crash during initialization.
Decisions
/,/healthcheck,/flush) to keep it focused>=5.75.0since that's when OpenFeature integration was added and the runtime behavior works correctlyRelated Issues