✅ Add Salesforce E2E tests#4761
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 9dc1458 | Docs | Datadog PR Page | Give us feedback! |
Bundles Sizes Evolution
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3942acb3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| launchOptions: { args: ['--disable-web-security'] }, | ||
| }) | ||
|
|
||
| createTest('salesforce') |
There was a problem hiding this comment.
Could you split this test into multiple tests?
There was a problem hiding this comment.
Yeah! I think I could also improve the coverage to resources, auto actions and etc. The only drawback is that for every test we generate a new url because each url is single use.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c60250763d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d97301961
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e23daa45a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
4757 adds the Salesforce LWC testing application with configurable init thru query params.
This PR wires up the full CI pipeline:
Changes
scripts/salesforce-lwc-app.ts: has 2 commands.deploy-appwhich redeploys the test application andget-urlwhich prints the authenticated salesforce url.datadogInit.jsby only injecting the init configuration as page.addInitScript.buildSalesforceLwcUrlthat authenticates at test time using the Salesforce API, so we don't import the scripts in the test.withSalesforceAppcreates the Salesforce Authenticated URL, overwrites the deployed bundle with the local one and injects the initScriptdd_RUM_CONFIGURATION.salesforceLWC.scenarioskips non chromium tests because the--disable-web-securityis chromium only and we need it so we can use our intake proxy to test. And the file tests initial view, custom action and route change.Test instructions
test/apps/sf-lwc-app/README.md— Authentication section), then:yarn test:e2e --grep salesforceChecklist