fix: allow errors from file manifest state provider to be caught by error boundary (#4601) #4607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
approved these changes
Dec 8, 2025
Contributor
frano-m
left a comment
frano-m
left a comment
There was a problem hiding this comment.
LGTM thanks @hunterckx 🍰
frano-m
force-pushed
the
hunter/4601-fix-file-manifest-error-handling
branch
from
44e82fb to
683f43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4601
This indirectly solves the endless request issue, as well as ensuring that the errors get displayed (but does not solve the broader issue of errors outside of the boundary potentially causing repeated renders -- see comments on DataBiosphere/findable-ui#711)