Remove "Network" path as required dir to run automactc.py on mounted … #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image "Network" path does not exist as an actual path on root for an OSX. Also, not everyone will have a network share or path mounted. Having this check essentially makes it impossible to run the automactc.py on a mounted image without removing that check. The current required_dirs seem sufficient to identify a typical OSX filesystem, however other directories could be added (They will be hidden) such as "private", "usr", or "sbin".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…image
"Network" path does not exist as an actual path on root for an OSX. Also, not everyone will have a network share or path mounted. Having this check essentially makes it impossible to run the automactc.py on a mounted image without removing that check. The current required_dirs seem sufficient to identify a typical OSX filesystem, however other directories could be added (They will be hidden) such as "private", "usr", or "sbin".