Skip to content

Conversation

@gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Dec 3, 2025

Note

Add Tinybird pipes for median time to merge/review and Gerrit patchsets per review with KPI and time-series outputs; fix TAGS in review_efficiency.

  • Tinybird pipes (new):
    • services/libs/tinybird/pipes/median_time_to_merge.pipe
      • Median seconds from PR open to merge; supports KPI or timeseries via granularity; filters by platform, startDate, endDate.
    • services/libs/tinybird/pipes/median_time_to_review.pipe
      • Median seconds from PR open to first review; KPI or timeseries; same filters as above.
    • services/libs/tinybird/pipes/patchsets_per_review.pipe
      • Gerrit-only patchsets-per-review metric; supports dataType (median|average), KPI or timeseries; time and repo filters.
  • Misc:
    • Fix TAGS formatting in services/libs/tinybird/pipes/review_efficiency.pipe.

Written by Cursor Bugbot for commit ea5c158. This will update automatically on new commits. Configure here.

@gaspergrom gaspergrom requested a review from epipav December 3, 2025 12:07
@gaspergrom gaspergrom self-assigned this Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@gaspergrom gaspergrom merged commit e7f46c2 into main Dec 17, 2025
12 checks passed
@gaspergrom gaspergrom deleted the feat/tb-new-pr-widgets branch December 17, 2025 11:04
@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

required=False,
)
}}
{% end %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Time window uses opened date, not merge

The time bucketing and startDate/endDate filtering use prf.openedAt while the metric is “time to merge”. This makes results depend on when PRs were opened rather than when they merged, so PRs opened in-range but merged later can appear, and PRs opened earlier but merged in-range are excluded, changing the meaning vs the widget being replaced.

Additional Locations (1)

Fix in Cursor Fix in Web

required=False,
)
}}
{% end %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Time window uses opened date, not review

The time bucketing and startDate/endDate filtering use prf.openedAt while the metric is “time to first review”. This makes results depend on when PRs were opened rather than when they were first reviewed, so PRs opened in-range but reviewed later can appear, and PRs opened earlier but reviewed in-range are excluded, shifting the widget’s meaning.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants