Skip to content

[Partner Nodes] chore(Ideogram): remove IdeogramV1 and IdeogramV2 nodes#14712

Merged
bigcat88 merged 2 commits into
masterfrom
chore/api-nodes/remove-ideogram-v1-v2-nodes
Jul 2, 2026
Merged

[Partner Nodes] chore(Ideogram): remove IdeogramV1 and IdeogramV2 nodes#14712
bigcat88 merged 2 commits into
masterfrom
chore/api-nodes/remove-ideogram-v1-v2-nodes

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Subj. PR completely removes those very old nodes.

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d7c0121-39fc-46dc-9639-6d438cef1a59

📥 Commits

Reviewing files that changed from the base of the PR and between dd17deb and ff7e406.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/ideogram.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_ideogram.py
💤 Files with no reviewable changes (1)
  • comfy_api_nodes/nodes_ideogram.py

📝 Walkthrough

Walkthrough

This change removes the IdeogramV1 and IdeogramV2 node classes from comfy_api_nodes/nodes_ideogram.py, along with their associated resolution/aspect-ratio mapping constants and now-unused imports. The IdeogramExtension.get_node_list() method is updated to return only IdeogramV3 and IdeogramV4. No new functionality is introduced; the change consists entirely of deletions and a corresponding update to the node list.

Changes

Cohort / File(s) Summary
comfy_api_nodes/nodes_ideogram.py Removed IdeogramV1 and IdeogramV2 classes, their mapping constants, related imports, and updated get_node_list() to list only V3/V4 nodes.

Related issues: None specified.

Related PRs: None specified.

Suggested labels: refactor, cleanup

Suggested reviewers: None specified.

Poem: A rabbit hopped through code so old,
Found V1 and V2, dusty and cold.
With a swish of the tail, away they did go,
Now V3 and V4 steal the show.
Fewer lines, cleaner ground —
Hop, hop, hooray, refactor found!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing IdeogramV1 and IdeogramV2 nodes.
Description check ✅ Passed The description is directly related and accurately says the PR removes the old nodes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bigcat88 bigcat88 merged commit 694815f into master Jul 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants