Skip to content

[Partner Nodes] feat(ByteDance): add 4K resolution support for SeeDance 2.0#14614

Merged
bigcat88 merged 1 commit into
masterfrom
feat/api-nodes/seedance-4k
Jun 24, 2026
Merged

[Partner Nodes] feat(ByteDance): add 4K resolution support for SeeDance 2.0#14614
bigcat88 merged 1 commit into
masterfrom
feat/api-nodes/seedance-4k

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Second try.

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

…ce 2.0

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request adds 4k resolution support to the Seedance 2.0 ByteDance video nodes. A 4k entry is added to the SEEDANCE2_RES_SHORT_SIDE mapping. The import switches from a static pricing constant (SEEDANCE2_PRICE_PER_1K_TOKENS) to a resolution-aware function (seedance2_price_per_1k_tokens), and _seedance2_price_extractor is updated to accept and forward a resolution parameter. The three affected nodes—Text-to-Video, First-Last-Frame, and Reference-to-Video—each receive 4k in their "Seedance 2.0" dynamic model options, updated price badge calculations that branch on resolution (and fast vs. non-fast model), and updated poll execution calls that pass resolution=model["resolution"] to the price extractor.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is only a generic "Second try" note and checklist, so it conveys little meaningful information about the 4K Seedance update. Add a brief summary of the actual change, such as enabling 4K resolution support and updating related pricing logic for Seedance 2.0.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: adding 4K support for ByteDance Seedance 2.0 nodes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_api_nodes/nodes_bytedance.py`:
- Line 2021: The SEEDANCE2 reference video pixel limit mapping is missing a 4k
entry, so the new 4k option bypasses the usual validation and scaling logic.
Update the SEEDANCE2_REF_VIDEO_PIXEL_LIMITS table to include a 4k key, and make
sure the existing reference-video flow in the SEEDANCE2 node path continues to
use it through _validate_ref_video_pixels and the auto-downscale/upscale
handling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8fc59c3f-bbd8-4074-9e3a-e55d39caa6d7

📥 Commits

Reviewing files that changed from the base of the PR and between cabb734 and 80d1609.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/bytedance.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_bytedance.py

Comment thread comfy_api_nodes/nodes_bytedance.py
@bigcat88 bigcat88 merged commit 5236cd0 into master Jun 24, 2026
22 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/seedance-4k branch June 24, 2026 14:58
zhangp365 pushed a commit to zhangp365/ComfyUI that referenced this pull request Jun 29, 2026
…ce 2.0 (Comfy-Org#14614)

Signed-off-by: bigcat88 <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants