-
Notifications
You must be signed in to change notification settings - Fork 31
feat: CodeConnect #3159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: CodeConnect #3159
Conversation
* new rulez * menu + disclosure
|
View your CI Pipeline Execution ↗ for commit 81def92 ☁️ Nx Cloud last updated this comment at |
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
dreamwasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all looks great to me minus my comments on the CodeConnected sections - i honestly am hoping other people's access tokens don't even work to push changes
The Figma implementation looks great for the connected code, even with the more complicated components like List 🔥
dreamwasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh - we prob wanna add a backlog ticket to convert this to a proper nx package (more for CI than anything else)
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://6969630a46313fa7a30ddf74--gamut-preview.netlify.app |
Overview
code-connectfolder in/packagescode-connectPR Checklist
Testing Instructions
Don't make me tap the sign.
/?path=/docs/meta-about--docs—-
Would love feedback on:
PR Links and Envs
N/A any changes are reflected in Storybook.
The
code-connectdirectory isn't part of thegamut-kitpackage.