Fix misc undefined behavior#313
Merged
Merged
Conversation
serprex
force-pushed
the
misc-undefined
branch
5 times, most recently
from
4d9b4e8 to
3f0b7d3
Compare
serprex
force-pushed
the
misc-undefined
branch
2 times, most recently
from
8dcb695 to
b963735
Compare
theory
approved these changes
Jul 10, 2026
1. kv_iter_next would access out of bounds with strlen when iter->togo == 1 2. CollapsingMergeTree was didn't validate well with bad parenthesis 3. CF_DATE_TRUNC/CF_DATE_PART didn't reject non-Const or null units 4. binary_simple_query was accessing state->coltypes[j] potentially out of bounds if column counts mismatched 5. volatile MemoryContext tempcxt needed for longjmp/setjmp semantics, added -Wclobbered to warn about this 6. char_to_datum would skip out of bounds on inputs without prefix 7. avoid calling convert_record / ch_binary_init_convert_state with NULL 8. `busy` should also be initialized in get_connection_entry 9. use typed curl_xferinfo_callback 10. curl_easy_escape returns NULL on failure, handle failure 11. DateTime64 scale bounded against lengthof(pow10i) for more hardening against malicious CH server 12. Wsign-compare
theory
reviewed
Jul 10, 2026
| v | ||
| --------- | ||
| () | ||
| ("(1)") |
Collaborator
There was a problem hiding this comment.
That doesn't look right. Should be:
((1))
No?
Member
Author
There was a problem hiding this comment.
no,
> select ROW(1),ROW(ROW(1));
row | row
-----+---------
(1) | ("(1)")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
busyshould also be initialized in get_connection_entry