Feature/spec generator#117
Open
KristinaGlyzina wants to merge 2 commits into
Open
Conversation
Collaborator
|
md файл переименуй в README.md и добавь пример использования пайплайн с CoolPrompt методом |
| @@ -1,7 +1,40 @@ | |||
| from pydantic import BaseModel, Field | |||
|
|
|||
| SUPPORTED_TASK_AREAS = [ | |||
Collaborator
There was a problem hiding this comment.
дубль с schema.py (разберись)
либо удали его тут
SUPPORTED_TASK_AREAS в кортеж
| from pathlib import Path | ||
| from pydantic import BaseModel, Field | ||
|
|
||
| TaskType = Literal[ |
Collaborator
There was a problem hiding this comment.
с 9 по 44 можно закинуть в utils
|
|
||
| class RequestBuilder: | ||
| def regular(self, spec: TaskSpec, task: Task, n: int) -> str: | ||
| return _REGULAR_TEMPLATES[task].format( |
Collaborator
There was a problem hiding this comment.
прямой индекс _REGULAR_TEMPLATES[task] / _CORNER_TEMPLATES[task] даст KeyError при неподдерживаемом Task (если использовать RequestBuilder вне текущего пайплайна).
можно сделать обработку возможной ошибки
| _DEFAULT_MAX_LEN = 4000 | ||
|
|
||
| _LEN_HINT_RE = re.compile( | ||
| r"(\d+)\s*(?:-|–|to)\s*(\d+)\s*(chars?|characters?|words?|symbols?)", |
Collaborator
There was a problem hiding this comment.
ругается тут на регекс посмотри
Collaborator
|
Будет ли работать пайплайн для генерации нового датасета (не из списка бенчмарков)? |
Collaborator
|
И добавь докстринги где их нет по классам и функциям |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.