fix: suppress AsyncMock RuntimeWarnings in Python 3.13+ #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
Member
|
What about using a separate branch for this second commit? :) |
tests/base.py
Outdated
Comment on lines
11
to
15
| warnings.filterwarnings( | ||
| "ignore", | ||
| message="coroutine .* was never awaited", | ||
| category=RuntimeWarning | ||
| ) |
Member
There was a problem hiding this comment.
We probably want to do something about this in the future then, but I'm fine with suppressing them for now.
cfsmp3
force-pushed
the
fix/async-mock-warnings
branch
4 times, most recently
from
e6b3d68 to
4c6bcf9
Compare
Contributor
Author
|
You're right - this PR currently includes both the AsyncMock warning fix AND the SQLAlchemy 2.0 changes, which makes it messy. The SQLAlchemy 2.0 upgrade is already in PR #998. This PR should be rebased to only include the AsyncMock warning fixes once PR #998 is merged. Would you prefer I:
|
Member
|
Rebase I'd say. GitHub can't do it. |
cfsmp3
force-pushed
the
fix/async-mock-warnings
branch
from
ebbf428 to
94dc99a
Compare
Member
|
Please get rid of the SQLAlchemy commit, it still holds changes from the original PR that were changed afterwards... |
In Python 3.13+, MagicMock auto-detects async-like method names (commit, debug, warning, etc.) and returns AsyncMock objects. This causes RuntimeWarnings when these methods are called synchronously. This commit adds: - A warning filter to suppress "coroutine was never awaited" warnings - A setup_mock_g() helper for tests that need explicit MagicMock setup - Updated create_mock_db_query() to also set up g.log 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
cfsmp3
force-pushed
the
fix/async-mock-warnings
branch
from
94dc99a to
4fca3d7
Compare
canihavesomecoffee
previously approved these changes
Jan 4, 2026
The code in mod_ci/controllers.py:1785 expects status objects with a .context attribute, but the test was returning dictionaries. This worked in earlier Python versions but fails in Python 3.14. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
canihavesomecoffee
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the RuntimeWarnings that appear when running tests with Python 3.13+:
Root cause
In Python 3.13+,
MagicMockautomatically returnsAsyncMockfor method calls that look async-like (such ascommit,debug,warning,error). When tests mock Flask'sgobject and the code callsg.db.commit()org.log.debug(...), Python warns that these coroutines were never awaited.Changes
warnings.filterwarnings()to suppress these specific warningssetup_mock_g()helper function for tests that need explicit MagicMock setupcreate_mock_db_query()to also set upg.logas a MagicMockTest plan
🤖 Generated with Claude Code