Skip to content

Conversation

@Vasist10
Copy link
Contributor

@Vasist10 Vasist10 commented Jan 1, 2026

Description

  • Added cycle detection to prevent task dependency loops (e.g., Task A → Task B → Task A).

  • DFS algorithm with O(V + E) complexity for optimal cycle detection

  • Validates dependencies during add/edit/modify operations

  • Fixes: Circular dependency in task dependencies #308

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@Vasist10
Copy link
Contributor Author

Vasist10 commented Jan 1, 2026

@its-me-abhishek The previous PR had some merge/commit history noise, so I opened this PR.

@its-me-abhishek
Copy link
Collaborator

@Vasist10 I had added a review in #323, kindly ACK that here wrt this PR

@Vasist10
Copy link
Contributor Author

Vasist10 commented Jan 1, 2026

@its-me-abhishek yes , i have made the change wrt to your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular dependency in task dependencies

2 participants