Skip to content

feat: add date and time pickers for all TaskWarrior time-based fields #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arjav1528 wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add date and time pickers for all TaskWarrior time-based fields #346

arjav1528 wants to merge 14 commits into from

Conversation

@arjav1528
Copy link

@arjav1528 arjav1528 commented Dec 30, 2025

Description

Add DateTimePicker support for due, start, end, entry, and wait fields in both TaskDialog and AddTaskDialog components. Users can now explicitly select time for precise scheduling instead of just dates. Backend updated to properly convert ISO datetime formats to TaskWarrior-compatible format for all time-based fields.

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

arjav1528 and others added 11 commits December 29, 2025 22:29
@arjav1528
feat(backend): add date conversion for all time-based fields in edit …
7e57cbf 
…task
@arjav1528
feat(backend): add date conversion for all time-based fields in add task
7791cbe
@arjav1528
feat(frontend): replace DatePicker with DateTimePicker for all time-b…
b9f791b 
…ased fields in TaskDialog
@arjav1528
feat(frontend): replace DatePicker with DateTimePicker for remaining …
5df160b 
…time-based fields in AddTaskDialog
@arjav1528
test(frontend): add tests for DateTimePicker in TaskDialog and AddTas…
bd985c6 
…kDialog
@arjav1528
Merge branch 'CCExtractor:main' into main
eb5e6cf
@arjav1528
refactor(frontend): remove unused DatePicker imports from task dialogs
82c8108
@arjav1528
test(frontend): remove unused variables in TaskDialog tests
700c55a
@arjav1528
test(frontend): fix date picker test placeholders and calendar button…
bcb810e 
… selection
@arjav1528
fix: prettier isues
7113e4c
@arjav1528
fix(test): remove unused variables in TaskDialog tests
9555c3e
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@its-me-abhishek
Copy link
Collaborator

its-me-abhishek commented Dec 30, 2025

@arjav1528 we have separate issues for AddTask Dialog and TaskDialog, so please revert the AddTask related changes from this PR

@arjav1528
feat(frontend): replace DatePicker with DateTimePicker in AddTaskDial…
6aafdc6 
…og and TaskDialog

- Replace DatePicker with DateTimePicker for all time-based fields in AddTaskDialog
- Replace DatePicker with DateTimePicker for all time-based fields in TaskDialog
- Update tests for DateTimePicker in both dialogs
@arjav1528
refactor(frontend): update TaskDialog tests to remove unnecessary par…
5ec4ff7 
…ameters
@arjav1528
Copy link
Author

arjav1528 commented Dec 30, 2025

@its-me-abhishek I have reverted Add Task and Add Task Dialog changes as you said

@its-me-abhishek
Copy link
Collaborator

its-me-abhishek commented Dec 30, 2025 •
edited
Loading

@arjav1528 There are still some file changes related to AddTask and TaskDialog, since we have done some work already, for migrating fields in TaskDialog, please revert any changes done to those files. Then get the latest upstream changes, and create a new PR updating only the AddTask dialog fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add additional time picker for time(and date) based fields in TaskDialog

2 participants

@arjav1528 @its-me-abhishek