Skip to content

feat(Chart): add ShowTotalDataLabel parameter#1062

Merged
ArgoZhang merged 5 commits into
masterfrom
feat-chart
Jul 11, 2026
Merged

feat(Chart): add ShowTotalDataLabel parameter#1062
ArgoZhang merged 5 commits into
masterfrom
feat-chart

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Jul 11, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #1061

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add support for showing total data labels on stacked charts.

New Features:

  • Introduce a ShowTotalDataLabel option in ChartOptions to control display of total labels on stacked bar chart columns.

Enhancements:

  • Refactor chart datalabel configuration to reuse a shared datalabels object and extend it with total label behavior when enabled.

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 11, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Jul 11, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds a ShowTotalDataLabel option to chart configuration and wires it into the JavaScript chart options to display total stacked values as data labels on bar tops when enabled.

File-Level Changes

Change Details Files
Introduce a reusable datalabels configuration object in the chart JS options and extend it to support total labels for stacked charts when ShowTotalDataLabel is enabled.
  • Create a datalabels object that centralizes anchor, align, formatter, display, color, and font settings instead of inlining them in the options block.
  • Add logic that, when total data labels are enabled and the X axis is stacked, computes the last visible dataset index and configures additional labels.value and labels.total entries.
  • Implement a total label formatter that sums visible dataset values for the current data index and only displays on the last visible dataset in the stack.
  • Wire the datalabels object into the chart options configuration by replacing the previous inline datalabels definition.
src/components/BootstrapBlazor.Chart/Components/Chart/Chart.razor.js
Expose a ShowTotalDataLabel configuration flag in the ChartOptions C# model to control total data label visibility in stacked mode.
  • Add a ShowTotalDataLabel boolean property with XML documentation describing its use for stacked bar total labels and default behavior.
src/components/BootstrapBlazor.Chart/Components/Chart/ChartOptions.cs
Update the chart project file to reflect the feature addition (likely versioning or packaging metadata).
  • Modify the chart project file, presumably to bump version or adjust metadata to accommodate the new option.
src/components/BootstrapBlazor.Chart/BootstrapBlazor.Chart.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#1061 Add a ShowTotalDataLabel parameter to the chart options and implement its behavior so that, when enabled in stacked mode, total data labels are shown at the top of each stacked bar.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit 2366fa9 into master Jul 11, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the feat-chart branch July 11, 2026 06:25

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The showTotalDataLabel logic currently only checks option.options.x.stacked; if horizontal stacked charts are supported, consider also handling y.stacked for consistent behavior.
  • The lastVisibleIndex helper is recreated and run on each label evaluation; consider extracting it or caching the last visible index per render cycle to avoid repeated iteration over all datasets.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `showTotalDataLabel` logic currently only checks `option.options.x.stacked`; if horizontal stacked charts are supported, consider also handling `y.stacked` for consistent behavior.
- The `lastVisibleIndex` helper is recreated and run on each label evaluation; consider extracting it or caching the last visible index per render cycle to avoid repeated iteration over all datasets.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Chart): add ShowTotalDataLabel parameter

1 participant