feat(Chart): add ShowTotalDataLabel parameter#1062
Merged
Conversation
# Conflicts: # src/components/BootstrapBlazor.Chart/BootstrapBlazor.Chart.csproj
Reviewer's GuideAdds a ShowTotalDataLabel option to chart configuration and wires it into the JavaScript chart options to display total stacked values as data labels on bar tops when enabled. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
showTotalDataLabellogic currently only checksoption.options.x.stacked; if horizontal stacked charts are supported, consider also handlingy.stackedfor consistent behavior. - The
lastVisibleIndexhelper is recreated and run on each label evaluation; consider extracting it or caching the last visible index per render cycle to avoid repeated iteration over all datasets.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `showTotalDataLabel` logic currently only checks `option.options.x.stacked`; if horizontal stacked charts are supported, consider also handling `y.stacked` for consistent behavior.
- The `lastVisibleIndex` helper is recreated and run on each label evaluation; consider extracting it or caching the last visible index per render cycle to avoid repeated iteration over all datasets.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1061
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for showing total data labels on stacked charts.
New Features:
Enhancements: