feat(Chart): add AutoSkip parameter#1060
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds support for configuring tick auto-skipping on chart axes by wiring a new AutoSkip property from the ChartAxes C# model through to the Chart.js ticks configuration for x, y, and secondary y (y2) axes. Sequence diagram for propagating AutoSkip to Chart.js tickssequenceDiagram
participant ChartAxes
participant ChartOption as option
participant getChartOption
participant ChartJS
ChartAxes->>ChartOption: set AutoSkip
ChartOption->>getChartOption: option.options.x.autoSkip
getChartOption->>ChartJS: configure x.ticks.autoSkip
ChartOption->>getChartOption: option.options.y.autoSkip
getChartOption->>ChartJS: configure y.ticks.autoSkip
ChartOption->>getChartOption: option.options.y2.autoSkip
getChartOption->>ChartJS: configure y2.ticks.autoSkip
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider defaulting
autoSkipinChart.razor.jswhen the value is undefined or null (e.g., falling back to Chart.js’ own defaults or the C# default) to avoid unexpected behavior if the options object is partially populated. - On the secondary Y axis (
y2), confirm that addingautoSkipinto the existingticksobject does not unintentionally override other tick-related configuration that might be set elsewhere; if necessary, merge with any existingticksoptions instead of redefining the object.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider defaulting `autoSkip` in `Chart.razor.js` when the value is undefined or null (e.g., falling back to Chart.js’ own defaults or the C# default) to avoid unexpected behavior if the options object is partially populated.
- On the secondary Y axis (`y2`), confirm that adding `autoSkip` into the existing `ticks` object does not unintentionally override other tick-related configuration that might be set elsewhere; if necessary, merge with any existing `ticks` options instead of redefining the object.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1059
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: