Skip to content

feat(Chart): add meger option logic #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 1 commit into from
Jul 11, 2026
Merged

feat(Chart): add meger option logic #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/BootstrapBlazor.Chart/Components/Chart/Chart.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ if (window.BootstrapBlazor.Chart === void 0) {
if (!elementMap.has(element)) {
elementMap.set(element, instance)
}
else {
deepMerge(elementMap.get(element), instance)
}

const data = Data.get(element);
if (data && data.chart) {
deepMerge(data.chart.config._config, instance);
Comment on lines +24 to +26

@sourcery-ai sourcery-ai Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Merging directly into data.chart.config._config may rely on internal/unstable Chart.js APIs and could break if _config changes.

data.chart.config._config appears to be an internal Chart.js structure rather than a stable public API. If Chart.js changes this field, the merge will start failing silently. Prefer merging into a documented config object (e.g. data.chart.config or data.chart.options) or using the library’s official update API instead.

data.chart.update();
}
}

getOptionsById(element) {
Expand Down
Loading