Ap 726 exclude files#80
Conversation
| if any(part.startswith(".") for part in relative_path.parts): | ||
| return False | ||
|
|
||
| if item.name.casefold() in {"thumbs.db"}: |
There was a problem hiding this comment.
I thought we wanted to make it configurable. Otherwise this seems like a decent enough implementation.
There was a problem hiding this comment.
I didn't see that in the ticket. Other than "." files and "Thumbs.db" I don't recall seeing other files we'd want to routinely exclude. Making it configurable wouldn't be hard but I won't have time to put that in along with test changes today. I'll be back Monday.
Could always be added later if needed though. It's only called by build_manifest though so probably not a big deal if other changes are merged first
There was a problem hiding this comment.
let's break out the configurability into its own ticket; we can merge this PR and i'll pick that up next.
steve-sullivan
left a comment
steve-sullivan
left a comment
There was a problem hiding this comment.
Looks good to me.
4 participants
No description provided.