Adding confirmation step for copying files#79
Merged
Conversation
awilfox
approved these changes
Jun 30, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+wc tiny nit regarding subject vs body otherwise this looks good to me!
Comment on lines
+10
to
+12
| DAG_DIR = Path(__file__).resolve().parent.parent.parent / "mokelumne" / "dags" | ||
| _DAG_BAG = DagBag(dag_folder=DAG_DIR.resolve(), include_examples=False) | ||
| DAG = _DAG_BAG.get_dag("copy_files") |
Member
There was a problem hiding this comment.
I am good with this right now, but as we add more DAGs, this is going to be duplicated everywhere. We should think about making a test utility method for retrieving a DAG out of the DagBag so that it's a single call.
Member
There was a problem hiding this comment.
should we make a ticket for that?
Contributor
Author
There was a problem hiding this comment.
That sounds good. I think I can create that and add it as a child to AP-549
anarchivist
approved these changes
Jun 30, 2026
anarchivist
left a comment
anarchivist
left a comment
Member
There was a problem hiding this comment.
r+; the suggestion is only a suggestion and not a formal change request.
Comment on lines
+10
to
+12
| DAG_DIR = Path(__file__).resolve().parent.parent.parent / "mokelumne" / "dags" | ||
| _DAG_BAG = DagBag(dag_folder=DAG_DIR.resolve(), include_examples=False) | ||
| DAG = _DAG_BAG.get_dag("copy_files") |
Member
There was a problem hiding this comment.
should we make a ticket for that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.