Feat: plash_download can overwrite empty dirs #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/plash_cli/pull/65 |
|
📖 Documentation Preview: https://plash-docs-pr-65.pla.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to timeout errors during downloading large apps, this PR makes the default timeout on all auth reqs to 300 seconds. Additionally, this PR modifies the behavior of
plash_downloadso that it is able to overwrite directories that are empty. This has been tested locally via plash-server's test e2e nbs and in the cli with some simple test cases.