Add durable reviewer sessions#2706
Open
BXya wants to merge 2 commits into
Open
Conversation
Author
|
Fork CI evidence is green on BXya#1 for the same branch/commit line. Passing checks on the fork PR:
Fork evidence PR: BXya#1 The upstream PR still needs maintainer approval to run workflows on AgentWrapper/agent-orchestrator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reviewerao spawn --role reviewerwith explicit harness and issue bindingScope
This only extends the existing durable session lifecycle. It does not change the PR review pane, add a reviewer UI lane, modify APL, or change GitHub writeback behavior.
Tests
go test ./internal/storage/sqlite/...go test ./internal/storage/sqlite/... ./internal/httpd/controllers ./internal/cli ./internal/service/session ./internal/adapters/agent/qwen ./internal/integration ./internal/skillassetsgo test ./internal/session_manager -run "TestSpawnReviewerPersistsAndRestoresKind|TestSpawnReviewerDoesNotInheritWorkerOverride"npm run apinpm run frontend:typecheckgit diff --checkKnown not green
go test ./...was not used as the gate because existing Windows/environment failures remain outside this reviewer-session change: auth fixture behavior, polluted PTY registry state, Windows mode bits, CRLF worktree expectations, HTTP port fallback, and path separator assertions.