-
Notifications
You must be signed in to change notification settings - Fork 0
#153 Removing obsolete GH Action, it's now part of Github & Dependabot update #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sn't support sbt (yet?)
WalkthroughRemoved the Dependabot sbt update block from Changes
Sequence Diagram(s)(omitted — changes are removal of config/workflow, not a new multi-component flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JaCoCo
|
| Overall Project | 59.84% | 🍏 |
|---|
There is no coverage information present for the Files changed
JaCoCo
|
| Overall Project | 70.17% | 🍏 |
|---|
There is no coverage information present for the Files changed
JaCoCo
|
| Overall Project | 91.42% | 🍏 |
|---|
There is no coverage information present for the Files changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
18-31: Correctly disabled, but consider implementing alternative solutions.The commented-out configuration is appropriate since Dependabot cannot update dependencies in build.sbt files. Native SBT support remains an open feature request in the Dependabot project.
However, this leaves your Scala dependencies without automated security scanning or update management. Consider implementing one of these alternatives:
For vulnerability scanning: Use the sbt-dependency-submission GitHub Action to submit dependencies to GitHub's Dependency submission API, enabling Dependabot alerts for vulnerabilities.
For automated dependency updates: Use Scala Steward, which creates pull requests to keep dependencies up-to-date and works specifically with Scala build tools.
Based on learnings, the repository has an existing release workflow using
sbt ci-release, so adding sbt-dependency-submission would complement your CI/CD setup well.Example sbt-dependency-submission workflow
Create
.github/workflows/dependency-graph.yml:name: Update Dependency Graph on: push: branches: - master jobs: update-graph: name: Update Dependency Graph runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - uses: scalacenter/sbt-dependency-submission@v2
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/dependabot.yml.github/workflows/dependent_items.yml
💤 Files with no reviewable changes (1)
- .github/workflows/dependent_items.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: benedeki
Repo: AbsaOSS/fa-db PR: 140
File: project/plugins.sbt:18-18
Timestamp: 2025-09-09T11:30:33.202Z
Learning: The fa-db repository at AbsaOSS/fa-db has an existing GitHub Actions workflow (.github/workflows/release.yml) that uses sbt ci-release with all required secrets (PGP_PASSPHRASE, PGP_SECRET, SONATYPE_PASSWORD, SONATYPE_USERNAME) properly configured for Maven Central publishing.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build, Test and Measure
- GitHub Check: Build, Test and Measure
- GitHub Check: Build, Test and Doc (2.12.17)
- GitHub Check: Build, Test and Doc (2.13.12)
Closes #153
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.