Skip to content

Conversation

@IvanGoncharov
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 8, 2025 23:13
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the navigation stack management system from an ID-based approach to an object-reference-based approach. The navigation state is now represented as a linked list structure (NavStack) that directly holds GraphQL type objects and type graph references, eliminating the need for ID-to-object lookups throughout the codebase.

  • Introduces NavStack type as a discriminated union for type list and type views
  • Replaces GraphSelection with direct type object references in callbacks
  • Updates all components to work with the new navigation model

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
webpack.config.ts Removes optimization: { minimize: true } setting from standalone build configuration
src/graph/viewport.ts Updates callbacks to use separate onSelectNode and onSelectEdge handlers; changes null checking from strict to loose equality
src/components/utils/SearchBox.tsx Refactors to sync local state with external value prop; updates null handling for search values
src/components/settings/Settings.tsx Adds undefined to typeGraph type to handle optional navigation stack
src/components/doc-explorer/TypeDoc.tsx Updates onSelectEdge callback to include from/to type objects alongside edge ID
src/components/doc-explorer/OtherSearchResults.tsx Adds null check for search value; updates callback signatures to match new pattern
src/components/doc-explorer/DocExplorer.tsx Major refactoring to use NavStack instead of local state; simplifies navigation logic by consuming stack from props
src/components/Voyager.tsx Core rewrite introducing NavStack type and management; implements new callback handlers for navigation, search, and selection
src/components/GraphViewport.tsx Adapts to NavStack-based props; implements adapter functions to convert between string IDs and type objects for viewport callbacks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IvanGoncharov IvanGoncharov merged commit 733ff47 into main Dec 20, 2025
18 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch December 20, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants