Skip to content

Conversation

@IvanGoncharov
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 7, 2025 14:27
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Dec 7, 2025
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the dotviz rendering API to expose render options up the call stack, making the API more flexible and explicit. Instead of hardcoding render options deep in the implementation, they can now be specified at the call site.

Key changes:

  • Introduced a RenderArgs interface to encapsulate both input and rendering options
  • Renamed renderString() to render() to reflect the broader parameter acceptance
  • Updated cache key generation to include render options alongside the input

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/graph/svg-renderer.ts Updated to call render() with explicit options object instead of renderString()
src/graph/graphviz-worker.ts Introduced RenderArgs interface, refactored methods to accept render options, and updated cache key generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IvanGoncharov IvanGoncharov merged commit d66b672 into main Dec 7, 2025
24 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch December 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants