Skip to content

desc for execution of scripts on system startup added #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prasannassp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

desc for execution of scripts on system startup added #7

prasannassp wants to merge 2 commits into from

Conversation

@prasannassp
Copy link

@prasannassp prasannassp commented Oct 23, 2020

Issue #1

@aquatiko
Copy link
Collaborator

aquatiko commented Oct 23, 2020

Thanks for the PR!
Couple of things to fix:

  • Please remove this file from commit. Looks redundant to me.
  • The corn job is what I was expecting from the issue.(Good thinking) But the current implementation runs the job on a fixed time specified by the user. We want it to be executed on system startup. Try to come up with action based cron.
  • Also, when you do finish can you add an example too? (why not use the taskkiller.sh for this?)
  • Maybe add a description in PR explaining how cron solves this issue.
  • (Bonus) Squash all commits into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prasannassp @aquatiko