use asyncIteratorSymbol helper to check for async Iterator #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lalitha-Iyer
changed the title
Lalitha-Iyer
changed the title
Lalitha-Iyer
changed the title
kitten
approved these changes
Apr 18, 2025
Member
kitten
left a comment
kitten
left a comment
There was a problem hiding this comment.
Nice catch! Very unintentional that this wasn't using the helper
Contributor
Author
|
Thanks for the quick review on this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix eliminates the possibility of a runtime error in environments without native support for
Symbol.asyncIteratorand async generators. In these environments it's likely Symbol.asyncIterator is not defined.Babel regenerator that transforms the source to support async generators falls back to "@@asyncIterator" when Symbol.asyncIterator is not available.
https://github.com/facebook/regenerator/blob/main/packages/runtime/runtime.js#L17
The fix is to use the existing "asyncIteratorSymbol" helper in Wonka to return the symbol for asynIterator, which accounts for filled-in support.
Set of changes