CMM-1071 jetpack android read view shows outdated post content (#22443)

* Reloading the content in every new load

* Fixing pull to refresh

* Detekt

* Removing dead code

Author: adalpari

WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.kt

@@ -1385,12 +1385,15 @@ class ReaderPostDetailFragment : ViewPagerFragment(),
 
                 // if the post has changed, reload it from the db and update the like/comment counts
                 if (result.isNewOrChanged) {
-                    viewModel.post = ReaderPostTable.getBlogPost(post.blogId, post.postId, false)
-                    viewModel.post?.let {
+                    val newPost = ReaderPostTable.getBlogPost(post.blogId, post.postId, false)
+                    newPost?.let {
+                        viewModel.post = it
                         if (likesEnhancementsFeatureConfig.isEnabled()) {
                             viewModel.onRefreshLikersData(it)
                         }
                         viewModel.onUpdatePost(it)
+                        // Re-render the WebView with updated content
+                        showPostInWebView(it)
                     }
                 }
 

WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/ReaderPostDetailViewModel.kt

@@ -391,34 +391,59 @@ class ReaderPostDetailViewModel @Inject constructor(
         launch { getOrFetchReaderPost(blogId = blogId, postId = postId) }
     }
 
+    @Suppress("CyclomaticComplexMethod")
     private suspend fun getOrFetchReaderPost(blogId: Long, postId: Long) {
         getReaderPostFromDb(blogId = blogId, postId = postId)
-        if (post == null) {
+
+        // Show cached content immediately if available, otherwise show loading
+        val hasCachedPost = post != null
+        if (hasCachedPost) {
+            updatePostDetailsUi()
+        } else {
             _uiState.value = LoadingUiState
-            when (readerFetchPostUseCase.fetchPost(blogId = blogId, postId = postId, isFeed = isFeed)) {
-                FetchReaderPostState.Success -> {
-                    getReaderPostFromDb(blogId, postId)
+        }
+
+        // Always fetch fresh content from the server
+        val oldPostText = post?.text
+        when (readerFetchPostUseCase.fetchPost(blogId = blogId, postId = postId, isFeed = isFeed)) {
+            FetchReaderPostState.Success -> {
+                getReaderPostFromDb(blogId, postId)
+                // Update UI if content changed or we didn't have cached content
+                if (!hasCachedPost || post?.text != oldPostText) {
                     updatePostDetailsUi()
                 }
+            }
 
-                FetchReaderPostState.AlreadyRunning -> {
+            FetchReaderPostState.AlreadyRunning -> {
+                if (!hasCachedPost) {
                     AppLog.i(T.READER, "reader post detail > fetch post already running")
                     _uiState.value = ErrorUiState(null)
                 }
+            }
 
-                FetchReaderPostState.Failed.NoNetwork ->
+            FetchReaderPostState.Failed.NoNetwork -> {
+                if (!hasCachedPost) {
                     _uiState.value = ErrorUiState(UiStringRes(R.string.no_network_message))
+                }
+            }
 
-                FetchReaderPostState.Failed.RequestFailed ->
+            FetchReaderPostState.Failed.RequestFailed -> {
+                if (!hasCachedPost) {
                     _uiState.value = ErrorUiState(UiStringRes(R.string.reader_err_get_post_generic))
+                }
+            }
 
-                FetchReaderPostState.Failed.NotAuthorised -> trackAndUpdateNotAuthorisedErrorState()
+            FetchReaderPostState.Failed.NotAuthorised -> {
+                if (!hasCachedPost) {
+                    trackAndUpdateNotAuthorisedErrorState()
+                }
+            }
 
-                FetchReaderPostState.Failed.PostNotFound ->
+            FetchReaderPostState.Failed.PostNotFound -> {
+                if (!hasCachedPost) {
                     _uiState.value = ErrorUiState(UiStringRes(R.string.reader_err_get_post_not_found))
+                }
             }
-        } else {
-            updatePostDetailsUi()
         }
     }
 

WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderPostDetailViewModelTest.kt

@@ -335,6 +335,10 @@ class ReaderPostDetailViewModelTest : BaseUnitTest() {
         whenever(commentsSnippetFeatureConfig.isEnabled()).thenReturn(true)
 
         likesCaptor = argumentCaptor()
+
+        // Default mock for fetch post - returns Success
+        whenever(readerFetchPostUseCase.fetchPost(anyLong(), anyLong(), anyBoolean()))
+            .thenReturn(FetchReaderPostState.Success)
     }
 
     /* SHOW POST - LOADING */