Skip to content

Conversation

@bo2themax
Copy link
Contributor

Notes

  • This configuration allows developers outside of the Wikipedia developer team to build and run on physical devices.

    Currently, only the Debug is using this configuration.

  • Add checks to the brew_install script to avoid unwanted upgrades for developers who are strict about tool versions.
  • Update ci_pre_xcodebuild to set up the default configuration, which should be the same as the previous project settings.

Test Steps

  1. Run scripts/setup

Screenshots/Videos

image

@l-olson1214
Copy link
Collaborator

Hi @bo2themax !
Wanted to let you know that we saw this and agree with it, but it may take a bit to merge so we can have enough time to thoroughly test it :)

Thanks!!

@tonisevener tonisevener self-requested a review October 27, 2025 20:53
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bo2themax! Thanks for working on this one and for your patience with our review. I found a couple of minor unused vars. I also notice when I run .scripts/setup from a freshly-cloned state, I see this error:

scripts/setup_bundle_id: line 15: scripts/../Configurations/OpenSourceDebug.xcconfig: No such file or directory

So maybe we should have the script create the Configurations directory in root if it doesn't already exist.

@bo2themax bo2themax force-pushed the support/custom_signing branch 2 times, most recently from bf9e898 to 9d9ab41 Compare November 1, 2025 12:53
@bo2themax
Copy link
Contributor Author

bo2themax commented Nov 1, 2025

Hi @bo2themax! Thanks for working on this one and for your patience with our review. I found a couple of minor unused vars. I also notice when I run .scripts/setup from a freshly-cloned state, I see this error:

scripts/setup_bundle_id: line 15: scripts/../Configurations/OpenSourceDebug.xcconfig: No such file or directory

So maybe we should have the script create the Configurations directory in root if it doesn't already exist.

Thank you @tonisevener! I haven't been able to install older virtual machines to test Xcode 15+, now it's working in a freshly cloned state with Xcode 16+.

Better to squash this pr if it's going into main.

This is the default one, which is basically the same one baked into the xcodeproj.
Check if each formula is installed, if not install it, do not upgrade against the user's wishes
Developers may also be using distributed provision files
@bo2themax bo2themax force-pushed the support/custom_signing branch from 04e7850 to 2a2dfdd Compare November 1, 2025 13:26
@bo2themax bo2themax requested a review from tonisevener November 1, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants